PCL: CosmeticCorrection module

[NKV]

Nikolay, since the BatchProprocessing script was updated to output multi-images fits (dark, low and high rejection maps all in one file), the CosmeticCorrection module fails to open the master dark being generated by the script. 

Would it be possible to update this module to properly read these new master images?

Done!

v 1.2.1 build 1
+ BatchProprocessing MasterDark Multi-images compatibility

[cs_pixinsight]

Thank you so much for your time on this one and the quick turnaround.

Craig

[Juan Conejero]

Hi Nikolay,

Thank you for catching up on this task.

I'll release this version as an update for all platforms. Is this version based on the official version's source code?

[NKV]

Is this version based on the official version's source code?

Yes, plus I renamed variables according your instruction about compatibility to PCL2.0.

[Philippe B.]

hello
I got a problem with newest version of this module :

When I select a MasterDark with enable hot pixels threshold, all the corrected files are corrupted (see right image below. Left if original)
I work under OSX 64bits with last release of PI and modules

thanks,
Philippe

[NKV]

Philippe, please upload one image for testing.

[Philippe B.]

Hi Nikolay
I just checked and it just happend on Mac OSX (64bits) version of newest Cosmetic Correction module (1.2.1.16)
On windows 64bit, it runs fine.

Also, on both platform, "real time preview" first time used show up an error message (violation error) without any consequence

Juan, could you have a look about this rendering bug ?

cheers

[Juan Conejero]

Hi Philippe,

Juan, could you have a look about this rendering bug ?

I'd be glad to do so, but as Nikolay has said, we need one of the images and the master dark you've used in order to understand what happens.

[Philippe B.]

Thanks,
I will prepare some images in few days (I am in vacation for the week),
Best,
Philippe

[zsikac]

Hello,

I experienced the same rendering bug with Linux 64-bits version (PI version 01.07.06.0793). The violation error for Real Time Preview appeared as well. It was tested on 64-bits Ubuntu 12.04.
Below is a link for the tested images (dark frame, calibrated image and calibrated image after application of CosmeticCorrection module):

nadhlavou.4fan.cz/public/M15_CC.zip

Regards,

Zdenek

[gvanhau]

Hello  Nikolay
I got a problem with this module, when enabling preview wo images, it opens a preview window which can not be closed  nor used anymore.
I get a message (see image).
No other module can use preview until you close PixInsigth.

I have tested it twice with the same result.

Regards
Geert

[NKV]

Hi friends.
Please give me some time to sort out the bugs.
Sorry for trouble,
Nikolay.

[NKV]

I experienced the same rendering bug

PrintScreen with CC settings please. I can't reproduce the problem without clear instruction.

[NKV]

I got a problem with this module, when enabling preview wo images

You mean RTP? As i know impossible to activate RTP without images, so PrintScreen with CC settings please. I can't reproduce the problem without clear instruction. 

[gvanhau]

Hi Nikolay
Thanks for your fast response

May be there is a mis understanding,
there is an active image in the workplace, but there are no images selected for processing in the module.

Here is the screenshot


Regards
Geert