Author Topic: PCL: CosmeticCorrection module  (Read 60008 times)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #90 on: 2012 August 27 23:23:27 »
there is an active image in the workplace, but there are no images selected for processing in the module.
CC is capable to apply RTP to any active image.
Please share the image with me?
There is mask in the image?

Offline zsikac

  • Newcomer
  • Posts: 3
Re: PCL: CosmeticCorrection module
« Reply #91 on: 2012 August 28 14:23:27 »
Hello Nikolay,

I appreciate your help. The PrintScreen with CC is attached here.

Kind regards

Zdenek

Offline gvanhau

  • PixInsight Old Hand
  • ****
  • Posts: 345
Re: PCL: CosmeticCorrection module
« Reply #92 on: 2012 August 28 18:51:16 »
Thanks Nikolay.

I found out that it happens only if the image has a mask.
For instance, I applied a lum mask to this image, and got the same result.

Regards
Geert

Geert Vanhauwaert

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #93 on: 2012 August 28 22:17:32 »
Geert, Zdenek,
Thank you for information. I will fix the bugs soon.

Best regards,
Nikolay.

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
Re: PCL: CosmeticCorrection module
« Reply #94 on: 2012 August 29 03:10:55 »
sorry I forgot to send images (too busy)
In my last processing I didn't get this error but I didn't use the masterdark for cosmeticcorrection (only the Auto with sigma 3.0 which has the most efficiency)

I experimented a freeze under Mountain Lion OSX 10.8.1 when using preview with masterDark and Auto sigma both but it is due to new version of Mountain Lion... so not your fault  ;)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #95 on: 2012 September 02 23:03:02 »
Juan, about the "exception bug" (example on picture): There is problem inside your official release.

How to get error: Run PI, run CC, click CFA checker. You must( or not? ) get exception like on attached picture.

How to solve: I just recompile source code and the problem disappear ( tested twice with CosmeticCorrection source code Version 01.02.01.0016 on win32 ) Maybe it's PCL 2.0 problem (BitmapStructure)?

Anyway, my compilation work fine. Who want use or test my version of CC module can download it from post #2.

Best regards,
Nikolay.

PS Please let me know if any problem.
« Last Edit: 2012 September 03 03:17:32 by NKV »

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: CosmeticCorrection module
« Reply #96 on: 2012 September 04 02:38:43 »
Hi Nikolay,

I cannot reproduce this problem on Linux, FreeBSD and Mac OS X, so it looks like a Windows-only problem (a compiler bug, perhaps). I cannot run a Windows virtual machine right now (we are in the middle of a thorough maintenance process) but I'll check this ASAP.

I prefer to postpone all non-vital updates until version 1.8. I'll double-check your module on all platforms before the official release, of course. Warren has already published a new video describing CC, where he has managed to avoid the bug, so no hurry for now.

Thank you for your nice work, as always.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #97 on: 2012 September 07 02:07:19 »
v 1.2.2 build 1 BugFix, BugFix.

Source code and module updated.


Best regards,
Nikolay.

Offline zsikac

  • Newcomer
  • Posts: 3
Re: PCL: CosmeticCorrection module
« Reply #98 on: 2012 September 13 12:44:17 »
Thanks a lot Nikolay,

for Linux 64-bit version it works.

Regards,

Zdenek

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #100 on: 2012 October 01 02:56:18 »
v 1.2.3 build 1
+ Corrected pixel count (log and FitsKeyword).

Offline johnw3d

  • Newcomer
  • Posts: 19
    • Flickr Astrophoto set
Re: PCL: CosmeticCorrection module
« Reply #101 on: 2012 November 13 16:47:41 »
Nikolai, is there any way to get a Mac OSX 64 bit build of 1.2.3?   Or can you point me at instructions for building same from the sources you posted?

It appears I have to check CFA even on mono images to get the correction to work properly with Master Darks.  If CFA is off, I get what appears to be convolving on all pixels, see below.   Note that Realtime Preview is correct, only issue is when processing a list of files.

Original:


Preview:


Processed:


Thanks,
John.
Tak FSQ-106EDX refractor, Optec focuser, 10Micron GM1000HPS mount, QHY9M + 2" filter wheel, Alnitak FlipFlat, Baader LRGB & Astrodon 3nm narrowband filters; Per's ModelMaker, SGP, PixInsight, LRCS, Photoshop

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #102 on: 2012 November 13 17:27:56 »
is there any way to get a Mac OSX 64 bit build of 1.2.3? 
Juan, please!!!

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: CosmeticCorrection module
« Reply #103 on: 2012 November 14 03:12:42 »
I'll try to build it ASAP. Right now the version of PCL that I have on *all* of our machines is incompatible with 1.7, so I have to recover an old backup. Allow me a couple days.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline johnw3d

  • Newcomer
  • Posts: 19
    • Flickr Astrophoto set
Re: PCL: CosmeticCorrection module
« Reply #104 on: 2013 January 19 14:14:39 »
I'll try to build it ASAP. Right now the version of PCL that I have on *all* of our machines is incompatible with 1.7, so I have to recover an old backup. Allow me a couple days.

This has been an issue for me for some while, I get around it by re-running CC over and over until it works, but this is no longer succeeding.   Is there any chance of getting a Max OSX 64 bit build of 1.2.3??

Please, please, please?

Thanks,
John.
Tak FSQ-106EDX refractor, Optec focuser, 10Micron GM1000HPS mount, QHY9M + 2" filter wheel, Alnitak FlipFlat, Baader LRGB & Astrodon 3nm narrowband filters; Per's ModelMaker, SGP, PixInsight, LRCS, Photoshop