Author Topic: RC1 deconvolution bug (osx)  (Read 4298 times)

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
RC1 deconvolution bug (osx)
« on: 2012 December 24 03:36:25 »
It's me again  >:D >:D

I tested DECONVOLUTION and I got some strange things with mask (no deconvolution rendering but patterns)
So I decided to test without mask but only a huge DERINGING to understand what happens (but use PSF generated by psf function:

image deconvolutionbug is taken with new version (it is not repeatable each time I make the process, horizontal pattern changes)

image deconvolution core 17 is taken with 1.7 version (same computer)


Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: RC1 deconvolution bug (osx)
« Reply #1 on: 2012 December 24 08:58:13 »
what happens if you turn off parallel processing in the global preferences?

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
Re: RC1 deconvolution bug (osx)
« Reply #2 on: 2012 December 24 10:40:40 »
Yes ! Working as it should do with parallel processing off
Thanks for the idea ! You pointed it out :)

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: RC1 deconvolution bug (osx)
« Reply #3 on: 2012 December 24 10:49:59 »
that confirms it then, i think there is some low level bug in how PI 1.8 is slicing up images for parallel processing. in the Debayer process the bug shows up as excessively long runtimes. i tried StarAlignment since i figured it would do a lot of multiprocessing but it worked fine. but then i remembered that juan was doing a lot of work on SA so of course it works :)


Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: RC1 deconvolution bug (osx)
« Reply #4 on: 2012 December 24 11:08:54 »
The same problem happens with LHE and StarMask (and probably with a few other tools, too), and the same workaround applies.

Quote
i think there is some low level bug in how PI 1.8 is slicing up images for parallel processing

It is actually more complex than that, but the problem is in the new multithreading model implemented in version 1.8.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: RC1 deconvolution bug (osx)
« Reply #5 on: 2012 December 26 03:16:41 »
Philippe,

I cannot reproduce this problem with Deconvolution. Could you please upload both images (the image to deconvolve and the deringing support) so I can investigate it?
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
Re: RC1 deconvolution bug (osx)
« Reply #6 on: 2012 December 26 09:48:31 »
Hi Juan
I sent you a MP with a small example

cheers

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: RC1 deconvolution bug (osx)
« Reply #7 on: 2012 December 29 03:14:18 »
This bug is now fixed by update 20121229-2-module, which we have released today. Thank you for your patience, and that you for uploading the two images, Philippe.

In addition, update 20121229-4-module also fixes a similar (and closely related) bug in the RestorationFilter tool.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
Re: RC1 deconvolution bug (osx)
« Reply #8 on: 2012 December 29 06:39:43 »
Don't worry Juan, a new release is not free of bugs !
It was very nice you provided us a RC1 version for testing
So I tested several process like some other peoples and we tell you where are the bug we found !

Thank you very much for your hard work and you quick reply to the coorection of the bugs ! No doubt in few weeks 1.8 will be a PERFECT release


So yesterdays... I found some strange things in SCRIPTS... lol
I will investigate more before open a topic :o)

cheers