Author Topic: HaRGBCombination Script  (Read 99176 times)

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: HaRGBCombination Script
« Reply #105 on: 2013 August 17 10:51:51 »
Maybe it is good idea to totally remove this part of the script ? People ? ideas ?

Definitely. I would suppress the color calibration section because it makes no sense IMO.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline marekc

  • PixInsight Addict
  • ***
  • Posts: 177
Re: HaRGBCombination Script
« Reply #106 on: 2013 August 17 10:55:31 »
Thanks for the workflow tips, Ioannis! I used the script as you described, and it worked great! I didn't have a lot of Ha data to add to my RGB Trifid, and the script gave me a nice subtle `bumping up' of the red nebulosity. Just what I was looking for!

Doing Background Neutralization and Color Calibration on the RGB image, *prior* to running the NBRGB script, as you suggested, seemed to give a better result than my previous attempt.

- Marek

Offline cornyyy

  • Newcomer
  • Posts: 10
Re: HaRGBCombination Script
« Reply #107 on: 2013 August 17 13:15:09 »
Hi Ioannis

thanks for the script improvement. It works great for my efforts. But can you mix the Halpha a bit into the blue channel as well to show the Hbeta Emission in the RGB also?

Thanks a lot
Cornel

Offline Ioannis Ioannou

  • PixInsight Addict
  • ***
  • Posts: 202
Re: HaRGBCombination Script
« Reply #108 on: 2013 August 18 06:40:48 »
OK, If anyone else does not have an objection, I'll remove (actually hide) the calibration part next version (not sure when because I'm leaving for business trip now). This will make the screen smaller and I will be able to re-arrange the components better. Of course any suggestion is more than welcomed.

cornyyy: the last script posted allows you to mix any narrowband filter to any of the three channels, as much as you want. Did you tried it ? You just have to put your Ha in both NBr and NBb and then trim the corresponding multipliers (or "Scales" as Juan suggested).  Please give it a try and let us know how it worked.

BUT, IMHO, this is not a good practice. Presence of Ha structures does not mean similar Hb structures - if you search the forum you will find an older post from Vicent demonstrating exactly this.
Clear Skies
John (Ioannis)

FSQ106N+Robofocus+QHY-22+SX USB wheel+Baader filters
SX OAG+DSI Pro guiding a NEQ6
PI for the rest :)

Offline cornyyy

  • Newcomer
  • Posts: 10
Re: HaRGBCombination Script
« Reply #109 on: 2013 August 28 01:17:56 »
Hello Ioannis,

sorry for my delayed reply... i was in vacation.

Thanks for your suggestion. I put the Halpha also in blue to simulate the Hbeta Emission. Are I am right, that the Multiplication factor 1.20 means 120%?

So if i want to mix the Halpha to the red and 15% into the blue channel, i had to adjust the multiplication sliders for red to 1.2 and for blue to 0.18?

Cheers
Cornel

Offline Ioannis Ioannou

  • PixInsight Addict
  • ***
  • Posts: 202
Re: HaRGBCombination Script
« Reply #110 on: 2013 August 28 05:51:37 »
Sorry for my late reply and not been able to produce newer version, currently also at vacations.
Yes, I think you are correct re 0.18.
Clear Skies
John (Ioannis)

FSQ106N+Robofocus+QHY-22+SX USB wheel+Baader filters
SX OAG+DSI Pro guiding a NEQ6
PI for the rest :)

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
Re: HaRGBCombination Script
« Reply #111 on: 2013 September 06 00:10:57 »
Nice job !
fore sure Color calibration is useless in this function.
We already have calibrated the RGB image, then add NB components.

Cheers,

Offline mads0100

  • PixInsight Addict
  • ***
  • Posts: 116
Re: HaRGBCombination Script
« Reply #112 on: 2013 September 07 16:40:07 »
Why hasn't this been added to the release yet?  It seems to work pretty well.

Also, is there any way to get the line 129 fixed in the release for us mac users?  It wasn't terribly hard to find but worth correcting.


Offline Ioannis Ioannou

  • PixInsight Addict
  • ***
  • Posts: 202
Re: HaRGBCombination Script
« Reply #113 on: 2013 September 07 23:04:52 »
Just come back and I will try to find some free time to make the changes agreed above.

Of course, Juan will decide for releasing it or not.

mads0100, what is the problem with line 129 you mentioned ?  Is this something in the latest script (NBRGBCombination ) ? Because I'm not aware of it.
Clear Skies
John (Ioannis)

FSQ106N+Robofocus+QHY-22+SX USB wheel+Baader filters
SX OAG+DSI Pro guiding a NEQ6
PI for the rest :)

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: HaRGBCombination Script
« Reply #114 on: 2013 September 08 02:18:16 »
Hi,

The color calibration section should be suppressed before releasing this script as an official update (I'd remove it completely, not just hide it, since it is a conceptual error). Along with this, I'd suggest some GUI improvements:

* The buttons in the preview section should be of fixed size and have just the necessary width. They should be stacked at one side (customarily, buttons are normally placed at the right side of previews and lists). The preview control should grow to fill all the available space.

* The channels control should be divided into four sections IMO: RGB, Red, Green and Blue.

* When the dialog is resized vertically an empty vertical space appears below the preview section. This should be removed and the preview control should grow vertically instead.

* Easy to fix but important: the spacing between standard Apply, Cancel and OK buttons should be 8 dialog units (now it's zero)
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Ioannis Ioannou

  • PixInsight Addict
  • ***
  • Posts: 202
Re: HaRGBCombination Script
« Reply #115 on: 2013 September 08 08:42:07 »
Which bring us to the next topic in subject: I took over maintenance of this script when Silvercup mentioned that had no time for it, and I wanted to improve it for my own workflow. Since then I put effort on it for fun, mostly when I used it for my images and had found something that could be improved during the process. But in any case, for me it was always a challenge on computer programming. I do have many many years experience on the topic, BUT:

1) I do not really know the programming language (but looks familiar and similar to many others). 
2) I do not really know the library used, or have documentation on it, other than browsing in the object explorer, looking into other people's code, periodically ask questions on the forum or just plain guessing.
3) I do not really have knowledge of the imaging methods and the maths used - again just guessing based on experience.

So, as you may understand, and considering that I do not really have an urge on an "official release", it will be difficult for me to put efforts on cosmetics or compliance on specific way of programming or look and feel.  I'm not saying that I can not do it  - although I do not know how to do a few things that Juan asked. For these I have to spend time to find out. Neither do I say I won't do it - it will just take me more time (never seem to have enough).

Simple putting it, it is not so fun for me right now, and if you wait me to implement all of these, it will take some time.

Sooo, considering that Silvercup gave the script with a "do whatever you want with it"  (meaning "public domain" in my book), anyone wanted to contribute at this stage, will be more than welcomed.


Clear Skies
John (Ioannis)

FSQ106N+Robofocus+QHY-22+SX USB wheel+Baader filters
SX OAG+DSI Pro guiding a NEQ6
PI for the rest :)

Offline topboxman

  • PixInsight Addict
  • ***
  • Posts: 292
    • Peter's Gallery
Re: HaRGBCombination Script
« Reply #116 on: 2013 September 08 11:14:10 »
Hi Juan,

Can you or your team tweak this script for official release? It would be quicker since you or your team have the most experience.

Thanks,
Peter

Offline jdonald

  • Member
  • *
  • Posts: 56
Re: HaRGBCombination Script
« Reply #117 on: 2013 September 13 10:50:39 »
Where do I download the script?

Offline Ioannis Ioannou

  • PixInsight Addict
  • ***
  • Posts: 202
Re: HaRGBCombination Script
« Reply #118 on: 2013 September 13 12:17:14 »
Previous page of this topic, so far the latest is attached on this message:
 http://pixinsight.com/forum/index.php?topic=3446.msg40130#msg40130

BTW my current tests with 6 filters (HaO3RGB) show good results.Anyone else tested it so far?

Pity that there are no people with scripting knowledge (and/or free time) to contribute on the code.
I'll have to find some free time to continue it.
Clear Skies
John (Ioannis)

FSQ106N+Robofocus+QHY-22+SX USB wheel+Baader filters
SX OAG+DSI Pro guiding a NEQ6
PI for the rest :)

Offline topboxman

  • PixInsight Addict
  • ***
  • Posts: 292
    • Peter's Gallery
Re: HaRGBCombination Script
« Reply #119 on: 2013 September 21 11:55:23 »
I have been using HaRGBCombination script with good success. Now with latest NBRGBCombination script I noticed that no matter how much I change the parameters, it does not appear to make any difference in the preview screen. But I noticed the difference in previous HaRGBCombination script. It seems that NBRGBCombination script may be using hard coded parameters and ignoring my settings.

Does anyone else see what I am seeing?

Peter