Author Topic: PCL: ImageInspection > AberrationInspector  (Read 16186 times)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
PCL: ImageInspection > AberrationInspector
« on: 2011 September 12 10:14:30 »
Hi,

The module do same as script version:
Quote
This module generates a n x n panel mosaic of subsections of a view.
Subsections are organized along horizontal and vertical bands across the view, including its corners, edges and central areas.

+ module can be applied to ImageContainer.
+ easy run via Alt+S.

Best regards,
Nikolay.

Source Code v1.1.2
bin Linux64
bin Win64
« Last Edit: 2016 January 29 03:05:20 by NKV »

Offline Enzo De Bernardini

  • PTeam Member
  • PixInsight Addict
  • ***
  • Posts: 274
  • Resistance is futile.
    • Astronomí­a Sur
Re: PCL: AberrationSpotter
« Reply #1 on: 2011 September 12 16:20:13 »
Works perfect in W32. Thanks!

Best,

Enzo.

Offline Nocturnal

  • PixInsight Jedi Council Member
  • *******
  • Posts: 2727
    • http://www.carpephoton.com
Re: PCL: AberrationSpotter
« Reply #2 on: 2011 September 12 16:40:48 »
Nice work Nicolay! PCL has a steep entry barrier but it's certainly worthwhile.
Best,

    Sander
---
Edge HD 1100
QHY-8 for imaging, IMG0H mono for guiding, video cameras for occulations
ASI224, QHY5L-IIc
HyperStar3
WO-M110ED+FR-III/TRF-2008
Takahashi EM-400
PIxInsight, DeepSkyStacker, PHD, Nebulosity

Offline Yuriy Toropin

  • PixInsight Addict
  • ***
  • Posts: 209
Re: PCL: AberrationSpotter
« Reply #3 on: 2011 September 13 02:53:36 »
Win x64 module. b0002
Works fine under Win7 x64 Ultimate SP1.
Thanks a lot!

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: AberrationSpotter
« Reply #4 on: 2011 September 28 05:21:29 »
Hi Nikolay,

Hmmm, I'm afraid Ctrl+A isn't a good idea here. I was thinking on using this key for the AutoSTF feature, which has been requested recently by many users. Sorry...  O:)  >:D
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: AberrationSpotter
« Reply #5 on: 2011 September 28 05:38:21 »
I'm afraid Ctrl+A isn't a good idea here.
What about Alt+S ?

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: AberrationSpotter
« Reply #6 on: 2011 September 28 10:08:53 »
Quote
What about Alt+S ?

That would be fine; I can't see any conflicts. You might consider allowing the user to select a custom key combination. This would require reimplementing MetaProcess::CanEditPreferences() and MetaProcess::EditPreferences().
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: AberrationSpotter
« Reply #7 on: 2011 September 28 11:17:18 »
Quote
What about Alt+S ?

That would be fine; I can't see any conflicts.
Done.  :)
See post #1.

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: AberrationSpotter
« Reply #8 on: 2011 September 29 08:18:35 »
You might consider allowing the user to select a custom key combination.
I can define ComboBox via code:
Code: [Select]
   KeyModifier_ComboBox.AddItem( "Shift key" );
   KeyModifier_ComboBox.AddItem( "Control key" );
   KeyModifier_ComboBox.AddItem( "Alt key" );
   KeyModifier_ComboBox.AddItem( "Space bar" );
   KeyModifier_ComboBox.AddItem( "Meta key (Mac OS X)" );
Also I can define Array and manipulate via "Control::OnKeyPress".

 Juan, can you show me more elegant way to populate "name" and "value" of KeyModifier and KeyCode?

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: AberrationSpotter
« Reply #9 on: 2011 September 30 00:02:13 »
allowing the user to select a custom key combination
But, how to check conflict with other PI modules?
I mean: If user chose "Ctrl+A" in my module - it will conflict with your AutoSTF.

How to GetAccelerator for all PI modules?

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: AberrationSpotter
« Reply #10 on: 2011 September 30 11:03:09 »
Quote
How to GetAccelerator for all PI modules?

You cannot. You have to leave this responsibility to the user. If she defines a keyboard combination that is already being used by another module or the Core application, the combination in question will become ambiguous and will cease to work.

Hopefully we'll have this feature in PCL 2.0.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: AberrationSpotter
« Reply #11 on: 2011 September 30 11:08:25 »
Quote
can you show me more elegant way to populate "name" and "value" of KeyModifier and KeyCode?

Actually... no :) I would do it exactly the same way you're doing: populate a ComboBox item by item. It isn't too much code (about 30 ComboBox::AddItem() calls), and if you use PCL symbolic constants (KeyCode::A, KeyCode::Zero, etc.) your code will be compatible with future PCL versions.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: AberrationSpotter
« Reply #12 on: 2011 October 01 05:25:06 »
You have to leave this responsibility to the user.
I think it's very dangerous way... because 99% PI users don't familiar with current PI keyboard combination.  :D

Anyway, next version b0007: Now possible to store current settings permanently. :)

Offline Nocturnal

  • PixInsight Jedi Council Member
  • *******
  • Posts: 2727
    • http://www.carpephoton.com
Re: PCL: AberrationSpotter
« Reply #13 on: 2011 October 01 06:35:59 »
I added the ability to store settings to my debayer module. I think it should be a standard feature on all modules. You can save all manner of fonts and colors with almost absurd detail but you can't save preferences for most of your processes. Sure you can save processes as psm files but that's not the same.
Best,

    Sander
---
Edge HD 1100
QHY-8 for imaging, IMG0H mono for guiding, video cameras for occulations
ASI224, QHY5L-IIc
HyperStar3
WO-M110ED+FR-III/TRF-2008
Takahashi EM-400
PIxInsight, DeepSkyStacker, PHD, Nebulosity

Offline Alejandro Tombolini

  • PTeam Member
  • PixInsight Jedi
  • *****
  • Posts: 1267
    • Próxima Sur
Re: PCL: AberrationSpotter
« Reply #14 on: 2011 October 01 07:53:11 »
Anyway, next version b0007: Now possible to store current settings permanently. :)

Hi Nikolay, Thank you for this tool!

The setting are saved in the module, but they do not have effect when Alt+S. The previous ones remain.

Saludos. Alejandro.