Author Topic: Blinking Script  (Read 87245 times)

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: Blink?
« Reply #75 on: 2010 May 31 13:40:12 »
Thanks for the speedy update Nikolay,

I don't have time to check it out tonight - I am 'late' with a critical project for work, so I need to prioritise :'(

As soon as I get a chance to have another 'play' I will get back to you.

Cheers,
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: Blink?
« Reply #76 on: 2010 June 03 09:00:40 »
Hi again Nikolai,

At last I have had another chance to look at the script again.

Very nice work :)

Whilst the GUI is maybe not immediately 'intuitive', a few moments spent 'getting the feel of it' and the system becomes quite 'workable' (just like any other PI interface !!)

I would like to see the ability to 'add', 'remove', 'clear all', 'select all' and 'invert selection', once the basic file list is loaded - have a quick look at my Batch deBayer GUI, which I 'stole' anyway - so I do not claim any originality whatsoever.

Basically, if I load 60 files, blink-animate these, and then decide I want to concentrate only on the first 10 (for example), it would be nice to 'deselect all' and 'select' the ten individual files - rather than having to quit the script and re-run.

Just a small detail ::)

I think your solution to 'BlinkMaster' would probably be OK. In any case, I don't really know how an A-B-C-D-E-F 'movie sequence' (with image A as BlinkMaster) would really look if it appeared as

A-B-A-C-A-D-A-E-A-F-A-B-A-C-A-D-A-E-A-F

Still, no matter what, it is great work. Can't thank you enough.

Cheers,
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: Blink?
« Reply #77 on: 2010 June 03 09:07:20 »
Another quick one Nikolay,

(I had pressed 'Post' too soon last time :()

I wonder whether the 'statistics.txt' file should 'auto-increment' in filename (statistics-0001.txt, statistics-0002.txt, etc.) if the process is repeated on the same directory of information?

And, the reason for this is based on my next request - and that is that 'statistics.txt' should be limited to 'only' those files still currently selected from the original list.

This would allow an instant 'overall' review of the files in a directory, then a secondary review of a selected subset

Please, feel free to tell me to shut up - and to leave you alone to do something else with your life - instead of just constantly re-writing your code to satisfy some crazy Scot :police: :police: :police: (who has only just realised that he didn't even manage to spell your name correctly last time !!)

Cheers,
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: Blink?
« Reply #78 on: 2010 June 07 03:40:55 »
Hi Niall.
Basically, if I load 60 files, blink-animate these, and then decide I want to concentrate only on the first 10 (for example), it would be nice to 'deselect all' and 'select' the ten individual files
Done. Use KeyBoard Shift / Alt / Space / Ctrl-A / Up / Done and mouse to select/deselect/invert selection.

Quote
A-B-A-C-A-D-A-E-A-F-A-B-A-C-A-D-A-E-A-F
Done. DoubleCkick to select BlinkMaster.

Quote
I wonder whether the 'statistics.txt' file should 'auto-increment' in filename (statistics-0001.txt, statistics-0002.txt, etc.) if the process is repeated on the same directory of information?
Done.

Quote
And, the reason for this is based on my next request - and that is that 'statistics.txt' should be limited to 'only' those files still currently selected from the original list.
Done.

Best regards,
Nikolay.

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: Blink?
« Reply #79 on: 2010 June 07 04:40:12 »
Hi Nikolai,

So, 'Done', 'Done', 'Done' and 'Done' - I am obviously not setting you difficult enough tasks >:D

Again, I can't test things right now - but, based on your previously 'stellar' performance, I am sure that everything will be fantastic when I run the script this evening.

Your efforts really have been an excellent service to all of us - raising the question as to whether this particular PJSR script needs to end up migrating into the 'core' of PixInsight, as a fully-fledged PCL module. However, now that PJSR scripts can allso raise 'Process Icons' themselves (not that I have tried to do this myself yet :-\), perhaps there really isn't any need. Your PJSR may be a perfect example of a 'scripted solution' being perfectly adequate for the job.

By the way - if I had the time (and your level of skill), my 'next step' would be to add <Tabs> to the GUI, allowing different 'groups' of files to all be collated and examined. This starts to lead forwards towards the DeepSkyStacker type of interface, where images are collated and previewed prior to a full calibration run being triggered. (So, please don't think that you are 'finished' - we (or, 'I') have LOTS of work ahead for you ::))

Thanks again.

Cheers,
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: Blink?
« Reply #80 on: 2010 June 07 04:59:51 »
So, please don't think that you are 'finished'
Yes, you are right. The script will grow.  :)
I am going to add <Tabs> to the GUI :footinmouth:

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: Blink?
« Reply #81 on: 2010 June 07 12:17:16 »
Hi

Really good this , many thanks for your work  :-*

Can we delete unwanted files from this script  ???


Harry
Harry Page

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: Blink?
« Reply #82 on: 2010 June 07 15:16:11 »
Hi Nikolai,

OK - I have just 'tested' the new script - and it is really becoming quite powerful now.

I am not entirely sure about all the keyboard and mouse-click combinationes yet - I am not saying that they are 'wrong' or that they are 'not intuitive', I just need some time to understand all the different combinations and permutations. But, I will also read the script program itself - to get an idea of how you have implemented it.

Constructive Criticism:

1.) I don't know how other users perceive what happens when the script first loads, and you have selected your 'batch' of files. As I said, I am selecting 60 images, where individual file sizes are only 1Mb. And I have an auxilliary monitor dedicated to the permanent display of the PI Console, so I can see what is 'happening'. My concern is that other users, with much larger files, who may not 'see' the Console showing that all of the files are being loaded into 'memory', might actually not realise what is happening during this phase.

2.) If the user clicks the 'red X' on the "Select files for Animation" dialogue, the next screen that appears is just a big blank window (much, much larger than your normal GUI) - with no indication of what is happening

3.) From (1) and (2), I think that a better 'open' for the script is needed. Perhaps you could present the 'normal' GUI that you are developing, but 'inhibit' some of the controls until such time as a valid file selection has been made

4.) I like the fact that the Statistics text file is now numbered sequentially - but I think it would be well worth the extra effort 'now' (whilst the project is still in its infancy) to get the numbering to conform to a -0001, -0002, -0003, ..... sequence rather than the 'un-sortable' -0, -1, -2, ..., -9, -10, -11 sequence

5.) Right now I am really struggling to understand the mode of operation of the four 'zoom' icons. I can see what they 'do', and I can make them all 'do something', and I can (eventually) get a view that I think I am after, but the interface is definitely NOT 'intuitive'. But, then again, it isn't 'intuitive' on the main PI image windows either. I would like to suggest alternatives for the ToolTips for these icons - but my brain is too sore tonight :'( I'll try again 'next time'

6.) I also need to just clarify, in my mind, how the STF application 'works'. I know it does, and quite well, but I just need some time to associate the behaviour with the icons and ToolTips)

Some ToolTip change suggestions:-
a) Right Arrow - change from "Next Image" to "Next image"
b) Play button - change from "Play" to "Play Animation" or "Run Animation"
c) Delay listbox - change from "Delay" to "Delay between images (sec)"
    - also, change the first ListBox entry title from "Unlimit" to "0.0 sec" (and change the higher three values to also display the '.0' decimal - the list will 'look nicer')

Please remember Nikolai - all these comments are meant to be 'constructive' - this script is going to become a very useful tool for eveyone, once they see how powerful it already is.

Cheers (and thanks again),
d) The 'Statistics' button - change from "Series Analysis report" to "Export Series Analysis text file to disc" (this may eventually require a user-option to decide whether every 'analysis' is always sent to the disc)
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: Blink?
« Reply #83 on: 2010 June 08 00:57:23 »
Hi Niall, thank you for criticism.
I am not entirely sure about all the keyboard and mouse-click combinationes yet - I am not saying that they are 'wrong' or that they are 'not intuitive', I just need some time to understand all the different combinations and permutations. But, I will also read the script program itself - to get an idea of how you have implemented it.
Current keyboard and mouse-click combinations it is standard PI combinations ;) I only stamped 'current selection' into 'Check Mark'. I prefer manipulate via 'Checked/Unchecked images', it's provide more clear visualization and understanding "whats happened?"

Quote
3.) From (1) and (2), I think that a better 'open' for the script is needed. Perhaps you could present the 'normal' GUI that you are developing, but 'inhibit' some of the controls until such time as a valid file selection has been made
When I start writing the script, I considered on fastest way to start movie, so I not like to ask users to do one more mouse click for load files... But script is growing and I will try, but many current buttons depend from opened images, so I should hide many control elements... I think to solve it via <Tabs> (Files/STF/Animation/Analyses/Settings/...)

Quote
-0001, -0002, -0003, ..... sequence
Fixed.

Quote
5.) Right now I am really struggling to understand the mode of operation of the four 'zoom' icons. I can see what they 'do', and I can make them all 'do something', and I can (eventually) get a view that I think I am after, but the interface is definitely NOT 'intuitive'. But, then again, it isn't 'intuitive' on the main PI image windows either.
You are right, it's just copy of PI interface and it's NOT 'intuitive'. I can rearrange zoom buttons vertically and put on left side ScrollControl window ( it's will exactly PI interface). Also I can add more button (zoom 1:2, 2:1). Let me know if you have any idea how to improve it.

Quote
6.) I also need to just clarify, in my mind, how the STF application 'works'. I know it does, and quite well, but I just need some time to associate the behaviour with the icons and ToolTips)
It's work like standard PI STF, I stole 'Auto Stretch' and 'Link RGB' code ;)

Quote
Some ToolTip change suggestions:-
Fixed. But, "Delay" changed to "Minimum delay between images (sec)", because the "0.0 sec" is only our wish and real delay will little bit more. ;)

Quote
d) The 'Statistics' button - change from "Series Analysis report" to "Export Series Analysis text file to disc"
I will if one of PI guru say:"I thinking and I will write Series Analysis tools. It's will like CCDInspector". But now I disagree with you. I want to grow the Analysis tools. Save to file (and show at console) is only simplest/fastest/temporary solution. I like to see not only 'numeric' report, because sometimes to understand which files is wrong don't need to ran other software (like Excel). Sometimes enough simplest Graphical report. But... but I write current 'Statistics' report only because button 'Auto Histogram Transformation to all images' share one engine with the 'Statistics' report. The AHT impossible without Statistics. So, why not... but I hope some of guru say me to kill my 'Statistics tools'.

Also, as you can see, Statistics for RGB images generate report by channels. I will populate the switcher soon. Now, if you like, you can change mode to false.
Code: [Select]
var mode=true;    // mode: sort by channel or not?
true
Image1-r
Image2-r
Image3-r

Image1-g
Image2-g
Image3-g

Image1-b
Image2-b
Image3-b




                         ?                          
false
Image1-r
Image1-g
Image1-b

Image2-r
Image2-g
Image2-b

Image3-r
Image3-g
Image3-b

And of course you can open and analyze RGB & BW images (or/and with different extension) in one pass. Should I destruct that possibility?

Best regards,
Nikolay.
« Last Edit: 2010 June 10 04:28:15 by NKV »

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: Blink?
« Reply #84 on: 2010 June 08 01:45:25 »
Juan, about STF and other External Objects:
Possible to run:
Code: [Select]
var st = new ScreenTransferFunction ();
st.launchInterface();
But how to kill or wait closing and collect result from?

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: Blink?
« Reply #85 on: 2010 June 08 14:50:06 »
Hi Nikolay,

Sorry - I am too tired to look at your latest incarnation tonight - but I will look again tomorrow.

It would be good to hear from others as well- you guys need to let Nikloay know that you are happy with his efforts. I am sure that this script will have a major role to play as PI develops. Now is your chance to get PI doing things that YOU need it to do.

Harry, I agree - once the GUI 'expands' (TABS and all) then there will be 'space' for extra buttons to allow the 'selected subset' to be either re-named and/or transferred to another directory (as happens with the ImageContainer, for example). I am sure that Nikolay will be keeping this in mind.

Cheers,
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: Blink?
« Reply #86 on: 2010 June 09 11:59:13 »
Ok, next version with new button: "Add Files"

2.) If the user clicks the 'red X' on the "Select files for Animation" dialogue
Niall, try to clicks the 'red X' now :)

Best regards,
Nikolay.

PS 'Close all' and 'Close selected' doesn't work, it is just decoration now.
« Last Edit: 2010 June 10 04:27:12 by NKV »

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: Blink?
« Reply #87 on: 2010 June 09 12:21:33 »
HI

I like the decoration  ;)

I keep saying it , but I appreciate the hard work

Harry
Harry Page

Offline RobF2

  • PixInsight Addict
  • ***
  • Posts: 189
  • Rob
    • Rob's Astropics
Re: Blink?
« Reply #88 on: 2010 June 09 23:03:04 »
Yep - just outstanding
This script is the first place I'm going now everytime a have more than few frames on an object, to get started on processing. 

 :P
FSQ106/8" Newt on NEQ6/HEQ5Pro via EQMOD | QHY9 | Guiding:  ZS80II/QHY5IIL | Canon 450D | DBK21 and other "stuff"
Rob's Astropics

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: Blink?
« Reply #89 on: 2010 June 10 01:57:39 »
Hi Nikolay,

Just a note to say that you're doing a terrific work. Definitely this has to be included in the next version. With 1.6.1, you'll be able to position windows and icons arbitrarily on PI workspaces (the new Workspace PJSR object), so your script will be even more shining ;)
Juan Conejero
PixInsight Development Team
http://pixinsight.com/