Author Topic: LarsonSekanina Convolution cosmetic bug  (Read 4465 times)

Offline RBA

  • PixInsight Guru
  • ****
  • Posts: 511
    • DeepSkyColors
LarsonSekanina Convolution cosmetic bug
« on: 2010 March 25 04:14:05 »
The parameters Radial Increment and Angular Increment show two sliders each. One of them is always inactive, but it's still there annoying the heck out of me  ;D

There should only be one slider per option, me thinks...

This is with PI SE, 01.05.09.0561 eng (x86_64) on Win7x64

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: LarsonSekanina Convolution cosmetic bug
« Reply #1 on: 2010 March 25 10:23:53 »
Just from what I remember (don't have PI here...). Those sliders work for different filter scales. The lower one, for small scale (0.1 to 10px), and the other, for larger ones. As soon as you reach the upper or lower boundary, the other slider should activate.
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline RBA

  • PixInsight Guru
  • ****
  • Posts: 511
    • DeepSkyColors
Re: LarsonSekanina Convolution cosmetic bug
« Reply #2 on: 2010 March 25 10:41:13 »
Just from what I remember (don't have PI here...). Those sliders work for different filter scales. The lower one, for small scale (0.1 to 10px), and the other, for larger ones. As soon as you reach the upper or lower boundary, the other slider should activate.

You are correct, sir. The bug was in my brain then. It's fixed now  :angel:

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: LarsonSekanina Convolution cosmetic bug
« Reply #3 on: 2010 March 26 01:48:39 »
Just for the record, LarsonSekanina needs a strong revamping. Its interface works, but it should be updated to meet current PCL standards. On the other hand, LS is an algorithm that I personally don't like, but this is only a personal feeling. Everything that can be "done" with LS can be done with wavelets, except the artifacts :)
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: LarsonSekanina Convolution cosmetic bug
« Reply #4 on: 2010 March 26 03:34:14 »
Yes, but we should redefine wavelets in a radial coordinate system.
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: LarsonSekanina Convolution cosmetic bug
« Reply #5 on: 2010 March 26 03:57:10 »
You can transform the image from Cartesian to polar coordinates, perform a wavelet transform, then the inverse transform from polar to Cartesian. We have all the required tools in PCL: PolarTransform and ATrousWaveletTransform. Sounds well doesn't it :)
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: LarsonSekanina Convolution cosmetic bug
« Reply #6 on: 2010 March 26 09:54:24 »
Hmmm... not convinced at all just for one problem: edge artifacts. I believe that the black pixels from "outside of boundaries" coordinate values in a R/Theta image will create a lot of them. Also, a common approach for the upper and lower boundaries (i.e. theta = 0 or 2Pi) may not work. It should be like a fourier function, not mirroing.
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com