Author Topic: Subframe Selector PCL Module  (Read 21763 times)

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4525
    • View Profile

Offline bvalente

  • Member
  • *
  • Posts: 55
    • View Profile

Offline souls33k3r

  • Newcomer
  • Posts: 21
    • View Profile
Re: Subframe Selector PCL Module
« Reply #92 on: 2018 November 19 14:54:30 »
awesome stuff. Cheers fellas. I knew i had to install it as a module but i was pointing at the .zip folder extracted contents. That‘s where i was going wrong. :)

Offline Subaru

  • Newcomer
  • Posts: 8
    • View Profile
Re: Subframe Selector PCL Module
« Reply #93 on: 2018 December 05 07:55:35 »
I tried to output the subframes with overwrite existing files enabled and a blank postfix, but encounter the following error.

I just want to add into the FITS header SSWEIGHT, as there are drizzle files attaching to the original registered files.

Using the new files cannot reuse the drizzle files.

This issue does not exist with the Subframe selector script.

Can you help?

Offline bvalente

  • Member
  • *
  • Posts: 55
    • View Profile
Re: Subframe Selector PCL Module
« Reply #94 on: 2018 December 05 09:58:10 »
is it possible that file is locked because it's open in another process or program?

Brian

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4525
    • View Profile
Re: Subframe Selector PCL Module
« Reply #95 on: 2018 December 05 10:23:59 »
if i understand what is being done, the file is locked because SFS has it simultaneously open for reading and writing.

sounds like you'll have to write the files to another directory then move the files back to the original directory (thus overwriting the originals) by hand.

the script version of this tool might be reading the whole image into memory, closing the file, then writing the file from memory to disk. the SFS process i guess works differently. cameron would have to comment.

rob

Offline cameronleger

  • PTeam Member
  • Member
  • *
  • Posts: 51
    • View Profile
    • Blog
Re: Subframe Selector PCL Module
« Reply #96 on: 2018 December 05 11:25:33 »
Rob is correct, but there's more information than just the image to transfer, and basically all of it is directly from the input file to the output file. I never imagined someone trying to replace the input images, so perhaps it needs to check for an empty pre/post-fix before attempting the process.

I'm not certain that reworking the read/write to support this use case is the best idea. At least in my processing and the other workflows I've seen, using the Subframe Selector would come before registration (and thus before any drizzle files exist). The most important reason for this is that, depending on how much the images are shifted from registration, you can massively skew the metrics it uses and improperly weight the images. Another less important reason is that you might want to use the process to determine which image you're registering to as a reference.

Offline bvalente

  • Member
  • *
  • Posts: 55
    • View Profile
Re: Subframe Selector PCL Module
« Reply #97 on: 2018 December 05 11:29:48 »
oh I see what's going on.

yeah, i have to bite the bullet and create a new set of image files when doing SFS. i do this prior to registration, which avoids your issue. it's extra disk space and hassle, but it works for me


hth


Brian

Offline cameronleger

  • PTeam Member
  • Member
  • *
  • Posts: 51
    • View Profile
    • Blog
Re: Subframe Selector PCL Module
« Reply #98 on: 2018 December 05 11:50:30 »
Rob's suggestion of using a different directory and moving them over the originals will work as well.

Overwriting files, especially the input files, is scary! It's unfortunate that it will take disk space, but basically every process will do this so it's not abnormal to me.

With a small drive, I'm frequently deleting the previous few steps' data if I'm comfortable running their processing again if I mess up, in order to be able to run most of my processing.

Offline Igor

  • Newcomer
  • Posts: 18
    • View Profile
Re: Subframe Selector PCL Module
« Reply #99 on: 2018 December 19 08:17:53 »
Hello Cameron,

I just used the SubframeSelector process in the last 1.8.6 release of PixInsight. It works very well. Great job thanks :-)

Nevertheless Output Files are .XSIF. Is threre any way to output files in .FIT (even if FITS is a deprecated file format) ?

Thanks

Regards

Igor

Offline bvalente

  • Member
  • *
  • Posts: 55
    • View Profile
Re: Subframe Selector PCL Module
« Reply #100 on: 2018 December 19 08:39:19 »
yeah - nice job on the final implementation. the floating panels will take some getting used to but it continues to be integral to my processing workflow


Brian

Offline cameronleger

  • PTeam Member
  • Member
  • *
  • Posts: 51
    • View Profile
    • Blog
Re: Subframe Selector PCL Module
« Reply #101 on: 2018 December 19 08:50:07 »
Hello Igor,
Thanks to Juan it now follows a pattern similar to most processes; that is initially hidden from the user but if you Edit the Instance's Source code with the icon at the bottom right, there's a parameter in there that you can change.

Offline Igor

  • Newcomer
  • Posts: 18
    • View Profile
Re: Subframe Selector PCL Module
« Reply #102 on: 2018 December 19 09:00:18 »
Very good ! Thanks Cameron  :)

Offline samlising

  • Newcomer
  • Posts: 9
    • View Profile
Re: Subframe Selector PCL Module
« Reply #103 on: 2018 December 19 13:25:06 »
Thanks Cameron for the great update to subframe selector.

I really like having both prefix and postfix available now. In the previous version on the script I hacked it so I could add a property like FWHM or Weight to the prefix or postfix of a file. Very useful for a quick sort of files. I'm wondering is there a way to add property variables to the postfix or prefix in the Subframe Selector PCL Module?

Thanks.
Sam

Offline cameronleger

  • PTeam Member
  • Member
  • *
  • Posts: 51
    • View Profile
    • Blog
Re: Subframe Selector PCL Module
« Reply #104 on: 2018 December 19 13:27:00 »
There is not, but that sounds like a good idea to me.