Warning in Background Neutralization

[Leandro VARGAS]

Hello,

I have the next warning in Background Neutralization each time I use the option Aggregated :

** Warning [156]: C:/Program Files/PixInsight/src/scripts/PreviewAggregator.js, line 293: assignment to undeclared variable n

This is normal warning ?

Thank you,

Leandro

[bitli]

No, it is not 'normal'. But in this case the warning can be ignored (I checked the code).

Unfortunately many scripts do not have a "use strict" directive or equivalent and have minor problems that generate warnings or could cause error if the script is run in strict mode (either because it is a new default or you ran a strict using strict mode before and PJSR remember it). So eventually this should be corrected.

If you want to remove the warning you can change the line 293 and add a missing 'var' on it (tested on PI 1.8 1092 it does the trick).
     

Code: [Select]

for (var n = 0; n < this.dialog.target_List.numberOfChildren; n++)but it is not required.

-- bitli

[Leandro VARGAS]

Bello Bitli,

Thank you for your comments, but the error was display when I run the process Pix BN.

Regards,

Leandro

[pfile]

that does not make sense, as the error has come from the script PreviewAggregator. maybe you ran it right before BN and did not notice it's output on the console until after you did BN?

rob

[Leandro VARGAS]

Hi

The step

- Sript Aggregator, no error durimg the process in console
- Process BN and during this process display the warning.

Leandro

[bitli]

Maybe the console was not flushed (not scrolled to the bottom, not visible when you ran the script, or something like that).  But the error

Code: [Select]

** Warning [156]: C:/Program Files/PixInsight/src/scripts/PreviewAggregator.js, line 293: assignment to undeclared variable n definitely come from PreviewAggregator and is easily reproduced (just add the "use strict"; at the first line to make it fatal).

Some scripts show or hide the console window depending on the fancy of the script programmer. Some of us make it  always visible on their desktop so we see warning immediately. May be BN is showing the console and this is why you see the warning only then.

There is always some logic to the behavior of PI.

-- bitli