Author Topic: PCL: Blink module  (Read 71288 times)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #15 on: 2011 November 26 20:44:03 »
How about releasing these tools through the update repository? If you agree, we can arrange it for next week.
Yes, please. I will happy!
Also, because more and more tools for analyzing images, perhaps it makes sense to put them in a separate folder. "menu>process>ImageInspection". If you agree, I will edit AberationSpoter and Blink modules according.

Best regards,
Nikolay.

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: Blink module
« Reply #16 on: 2012 January 07 03:46:27 »
Hi Nikolay,

Well, everything seems to be relatively quiet now (translation: I only have to do the work of 2-4 persons, instead of 4-6), so I think it's time to review and release these nice modules. I refer to this one and StarMonitor. I need the source code for revision and to prepare a release for all platforms. Are you ready?
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #17 on: 2012 January 10 19:32:09 »
Are you ready?
Yes! I mailed SCode for Blink module to you.

About StarMonitor, I think the module not yet ready. I wont add more features soon.

Best regards,
Nikolay.

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: PCL: Blink module
« Reply #18 on: 2012 January 21 16:15:56 »
Just got the update for the blink module in PI. Fantastic work. Used it immediately. Wishlist (of course, what else. Appetite comes with eating):
- blue triange for storing current settings
- help button with documentation
- it would be nice to be able to sort the images by values of the statistics. Clicking on the column head should to this trick.
- would it be possible to not only include FITS keywords, but also values embedded in RAW file, such as aperture, time+date of exposure, ...? I see that it already gets the exposure length.
- would it be possible to add RAW format hints (as in image calibration for example)?

Great tool!

Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #19 on: 2012 January 22 03:28:31 »
Juan, thank you for publish the module. And thank you for fix the code ( for me very interesting to see how you fix some parts ).

Georg, give me a some days.

Best regards,
Nikolay.

Offline troypiggo

  • PixInsight Addict
  • ***
  • Posts: 258
Re: PCL: Blink module
« Reply #20 on: 2012 January 22 13:22:18 »
Is this a Windows-only module?  Nothing for Mac?

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: PCL: Blink module
« Reply #21 on: 2012 January 22 13:33:01 »
no, the mac version is included in the official update that just came down. i used it last night - it can animate really fast compared to the script version!

Offline troypiggo

  • PixInsight Addict
  • ***
  • Posts: 258
Re: PCL: Blink module
« Reply #22 on: 2012 January 22 17:36:12 »
Aah, I see.  Just downloaded it and played with it.  Awesome!  Thankyou!

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #23 on: 2012 January 25 20:12:57 »
Hello Juan,

You changed logic of the module at close of the user interface.
The module displays pictures from memory. A lot of pictures = a lot of memory. My version is freed memory when user hide the interface. (push X at TopRight)
Your version leaves all the images in memory until the user forcibly remove the files from the interface.
I guess that is not an advanced user will be surprised, not knowing why PI has taken so much memory.

Perhaps it makes sense to notify the user and to make a choice when user hide the interface? Dialog pops up: "Free memory? Yes / No"

Waiting for your opinion
Nikolay.

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: Blink module
« Reply #24 on: 2012 January 25 23:52:52 »
Hi Nikolay

The OnHide() event is generated each time the interface is hidden with respect to PI's workspace. That means this event will be received (1) when the interface is shadowed, (2) when the user switches between workspaces, (3) when the interface is closed by clicking the x button, and since interfaces are top-level windows, (4) as a result of platform-dependent spontaneous hide events sent by the underlying operating system and/or window manager. Currently there's no way to know the actual reason that has triggered an OnHide() event. In future versions of PCL we'll have a richer set of events available to the Control and ProcessInterface classes.

I disabled the automatic memory clear feature mainly due to (1) and (2), as it is very annoying to have everything lost during a Blink session each time you want to minimize the interface, or if you have to change momentarily to a different workspace for any reason. On the other hand, the standard behavior of all static tools in PixInsight is to preserve their current settings, irrespective of whether their windows are visible or not, and Blink shouldn't be an exception. In fact, I think most experienced PixInsight users would be surprised if all selected files are lost when they open the Blink tool after a previous session.

Don't worry about memory consumption in the Blink tool. Once a set of images has been loaded, the user is responsible for their deallocation when they are no longer needed. A warning message box each time the tool is hidden would generate more annoyance than benefit, in my opinion.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #25 on: 2012 January 26 00:35:46 »
Thank you for explanation. Now I absolutely agree with you.
Best regards,
Nikolay.

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #26 on: 2012 January 28 06:58:17 »
- it would be nice to be able to sort the images by values of the statistics. Clicking on the column head should to this trick.
There are problem: I don't see PCL event handler on TreeBox sorting by mouse click on TreeBox Header. So, I don't know when I must re-calculate real blinkMaster position after sorting. I need onTreeBoxHeaderClick event handler. Juan ???

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: Blink module
« Reply #27 on: 2012 January 28 08:11:07 »
Have you tried with:

TreeBox::EnableHeaderSorting()

If you call this member function for your TreeBox control (for example, in BlinkInterface::GUIData::GUIData()), the user will be able to sort files by header items, by clicking them in the usual way.

Let me know if this is what you want to do. The upcoming new PCL version will provide more event handlers to control TreeBox header items.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #28 on: 2012 January 28 09:27:12 »
I know about TreeBox::EnableHeaderSorting(), but if user click(sort row by header items) I need to know about. So I need event handler.

 
« Last Edit: 2012 January 28 20:36:09 by NKV »

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: Blink module
« Reply #29 on: 2012 January 29 21:48:52 »
- it would be nice to be able to sort the images by values of the statistics. Clicking on the column head should to this trick.
Done. Ver.1.0.5 in post#1