Author Topic: PCL: CosmeticCorrection module  (Read 60006 times)

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: PCL: CosmeticCorrection module
« Reply #105 on: 2013 January 19 14:40:16 »
let me try building it.
rob

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: PCL: CosmeticCorrection module
« Reply #106 on: 2013 January 19 16:41:38 »
okay, x86 and x86_64 versions in the zipfile below.

https://www.dropbox.com/s/m4xapus1huix3zp/CosmeticCorrection_v1.2.3.2_PI1.7_osx.zip

interestingly, when i asked PixInsight 1.7 to install this module from the Release directory, presumably because there was already a CosmeticCorrection dylib in the application bundle, it threw a very cryptic error and refused to install the module.

Offline johnw3d

  • Newcomer
  • Posts: 19
    • Flickr Astrophoto set
Re: PCL: CosmeticCorrection module
« Reply #107 on: 2013 January 20 20:59:16 »
okay, x86 and x86_64 versions in the zipfile below. ...

Wow, thanks so much, Rob.   This did indeed fix the problem I've been having, :-}}.   How did you build it, do you have the sources?

Thanks again!
John.
Tak FSQ-106EDX refractor, Optec focuser, 10Micron GM1000HPS mount, QHY9M + 2" filter wheel, Alnitak FlipFlat, Baader LRGB & Astrodon 3nm narrowband filters; Per's ModelMaker, SGP, PixInsight, LRCS, Photoshop

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: PCL: CosmeticCorrection module
« Reply #108 on: 2013 January 20 23:17:44 »
cool. well NKV has posted the source code on the first page of the thread, and i have the PCL environment and Xcode on my machine, so... generated a makefile with PI and built. had problems at first but Nikolay has a flag in there that makes the source compatible with the 'old' PCL; switching that flag on fixed those problems.

Offline sreilly

  • PixInsight Padawan
  • ****
  • Posts: 791
    • Imaging at Dogwood Ridge Observatory
Re: PCL: CosmeticCorrection module
« Reply #109 on: 2013 February 09 15:29:19 »
well I finally found the cosmetic correction module and have it downloaded but can not find a way to install it. I've tried the install module and searching the download directory where I downloaded and extracted the file but it doesn't seem to see it. Where am I going wrong?
Steve
www.astral-imaging.com
AP1200
OGS 12.5" RC
Tak FSQ-106ED
ST10XME/CFW8/AO8
STL-11000M/FW8/AO-L
Pyxis 3" Rotator
Baader LRGBHa Filters
PixInsight/MaxIm/ACP/Registar/Mira AP/PS CS5

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: PCL: CosmeticCorrection module
« Reply #110 on: 2013 February 09 20:13:22 »
i usually copy the file into the area where pixinsight stores the rest of the modules. on OSX this is /Applications/PixInsight64.app/Contents/MacOS/ but i don't know about windows and linux. (/Applications/PixInsight64.app is the default; if you have renamed Pixinsight or have installed the program somewhere else than /Applications then you need to substitute the applicable path.)

then i do Process > Install Modules in that directory and the process is installed...

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: PCL: CosmeticCorrection module
« Reply #111 on: 2013 February 10 02:30:30 »
CosmeticCorrection came with my 1.8RC3 install. There should be no need to install it from elsewhere.
Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #112 on: 2013 February 10 07:46:42 »
CosmeticCorrection came with my 1.8RC3 install. There should be no need to install it from elsewhere.
+1

Offline sreilly

  • PixInsight Padawan
  • ****
  • Posts: 791
    • Imaging at Dogwood Ridge Observatory
Re: PCL: CosmeticCorrection module
« Reply #113 on: 2013 February 11 06:54:48 »
Seems I got ahead of myself. Let me see if I have this straight, modules are processes and scripts are not? Regardless I do have 1.8 RC3 now installed and watched Harry's video on the Batch Preprocessing usage which includes some information on using the Cosmetic Correction process which is helpful but I've run into an issue. For those that haven't seen my posting on this I started a thread "Topic: Hot/Cold Pixels" and seem to have some issues with getting all the defects. http://pixinsight.com/forum/index.php?topic=5220.new;topicseen#new

The latest images I'm using are taken with my FSQ-106 at f/5 and this is where I seem to be having problems. The image scale isn't ideal at 3.49 arc seconds per pixel but I need to have my 12.5" RC optics re-coated so I started using the FSQ in the mean time. Seeing how I use the same camera on both, would it be better to model the defects using the RC frames, .48 arc seconds per pixel, and the images are at -30C for the same time period, the hot/cold pixels would/should be identical? Or am I making this too difficult? It would probably help to be able to zoom in on the live preview window but I don't see how.

My understanding is that once the settings return a good result, you can save the CC setup as a process icon to use over and over. My only other usage of taking care of hot/dead pixels was using MaxImDl and the Kernel filter. There the setting I use is 80% for the dead threshold and 20% for hot pixel which has always worked great. In CC we have a sigma setting, how does this correlate or is there a better way for me to understand how to achieve optimal settings. I can post a raw image and dark on my website for anyone interested in looking at this but would prefer to reach the proper use by learning what I actually should do.

Any suggestions would be greatly appreciated.

Thanks,

Steve
Steve
www.astral-imaging.com
AP1200
OGS 12.5" RC
Tak FSQ-106ED
ST10XME/CFW8/AO8
STL-11000M/FW8/AO-L
Pyxis 3" Rotator
Baader LRGBHa Filters
PixInsight/MaxIm/ACP/Registar/Mira AP/PS CS5

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: PCL: CosmeticCorrection module
« Reply #114 on: 2013 February 11 10:36:32 »
Hi

What scope you are using does not matter a hot pixel is a hot Pixel  >:D

As for the sigma setting ( plenty on line about sigma) of course there is no magic setting  ;D  a setting of 3 works well with a lot of cameras , but I need about 2.5 to remove most of my hot pixels

It is fairley easy to see how pixels are being corrected by number and apply it to a single image to see the results ,  Any that are missed Intergration sorts them out with another Sigma rejection  ;D

Harry
Harry Page

Offline sreilly

  • PixInsight Padawan
  • ****
  • Posts: 791
    • Imaging at Dogwood Ridge Observatory
Re: PCL: Cosmetic Correction module
« Reply #115 on: 2013 February 11 16:15:10 »
My reference to pixel scale was that using the FSQ the stars are much smaller so the pixel defects are less noticeable than those images at a much smaller image scale. Thanks for your reply. I'll try various sigma settings and see what they develop!

Thanks again
Steve
www.astral-imaging.com
AP1200
OGS 12.5" RC
Tak FSQ-106ED
ST10XME/CFW8/AO8
STL-11000M/FW8/AO-L
Pyxis 3" Rotator
Baader LRGBHa Filters
PixInsight/MaxIm/ACP/Registar/Mira AP/PS CS5

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: PCL: CosmeticCorrection module
« Reply #116 on: 2013 July 21 13:04:11 »
Hi

I am looking at some DSLR data for someone , and are wondering how you can use the tool with dslr data

Any tip would be great

Harry
Harry Page

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #117 on: 2013 December 13 01:38:19 »
Build 1065: Don't try to process image which size less then 13x13 pixels in CFA mode and and 7x7 in non CFA. Because module cannot calculate correct background data at small images. RTP show wrong data on PreView too.

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #118 on: 2013 December 15 03:01:17 »
v 1.2.4 Add warning, if view to small for correct RTP calculation.