Author Topic: PCL: CosmeticCorrection module  (Read 60063 times)

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: CosmeticCorrection module
« Reply #30 on: 2012 February 21 09:53:14 »
Nikolay,

Is this module ready for release? I can build it for all platforms as soon as you say it's ready.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #31 on: 2012 February 21 10:11:34 »
Nikolay,

Is this module ready for release? I can build it for all platforms as soon as you say it's ready.
Juan, I don't like how look interface, especially in RTP section. If there are any idea how to improve it, please push me.
Also I think, need some time for catch bugs, if there are...

Otherwise, You will need build bug updates very soon.

Best regards,
Nikolay.

PS What about publication update for Blink?

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: PCL: CosmeticCorrection module
« Reply #32 on: 2012 February 21 15:34:52 »
Nikolay,

how about publishing modules that are not yet perfect but which you would like to see tested by a larger community in the Update-Development repository, see http://pixinsight.com/forum/index.php?topic=3335.0 . For the GradientMergeMosaic process, this helped to find a lot of nasty issues fairly quickly.

Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #33 on: 2012 February 22 22:47:24 »
v 1.1.0. buid 4
Temporary, BigFix version: In previous release there are potential bugs in not important features( Invert with STF and not *.fit file support ) . I don't have solution for those bugs. So I temporary disabled those features.

how about publishing modules that are not yet perfect but which you would like to see tested by a larger community in the Update-Development repository, see http://pixinsight.com/forum/index.php?topic=3335.0 . For the GradientMergeMosaic process, this helped to find a lot of nasty issues fairly quickly.
Georg, good idea. I will ask Juan after solving that problem http://pixinsight.com/forum/index.php?topic=3881.0
I say "after" because actually, current version is 32bit limited, so I must rewrite InstanceEngine parts of the module.

Best regards,
Nikolay.

Offline mmirot

  • PixInsight Padawan
  • ****
  • Posts: 881
Re: PCL: CosmeticCorrection module
« Reply #34 on: 2012 March 01 06:31:36 »
I had trouble with the 64 bit version. I could not get RT preview to start.

Max

Offline mmirot

  • PixInsight Padawan
  • ****
  • Posts: 881
Re: PCL: CosmeticCorrection module
« Reply #35 on: 2012 March 01 19:02:23 »
Got it Ok now

Max

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #36 on: 2012 March 08 12:02:48 »
v 1.2.0 build 1
+ List of Defects: Entering manually Row/Column defects and Save/Load text file.

I had trouble with the 64 bit version. I could not get RT preview to start.
When RTP starting, depend on selected correction methods, RTP engine prepare up to 5 defective map images.(ColdMasterDarkMap, HotMasterDarkMap, AutoColdMap, AutoHotMap, MapFromDefectiveList).
Plus 3 MorphologicalTransformation Light images ( Average 3x3, Median 3x3, BackGroundMedian 7x7 ). In CFA case size of MorphologicalTransformation Structure have double size.
For example: AutoDetectHot/Cold require all type of MT Light images plus require ImageStatistics. AutoDetect is very slow method, but as you can see on PrintScreen provide result similar to fastest DefectiveList method. See Screen.

So, if you try start RTP on full size MainView image a lot of preparation required.
If you like fast RTP start, just start it on small preview window.

Offline troypiggo

  • PixInsight Addict
  • ***
  • Posts: 258
Re: PCL: CosmeticCorrection module
« Reply #37 on: 2012 March 08 13:32:29 »
Not clear reading through this if there's been an OSX 64 bit version compiled?

On a side note, I have downloaded the js version.  Wondering what the differences/benefits of PCL version are?  If there's a js and PCL version available, same features, is one better than the other?

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #38 on: 2012 March 08 21:46:33 »
Not clear reading through this if there's been an OSX 64 bit version compiled?
OSX is not available.

To Juan: Can you compile it for other OS? And publish it via Update-Development repository? Please.

Quote
Wondering what the differences/benefits of PCL version are?  If there's a js and PCL version available, same features, is one better than the other?
JS vs PCL:  :D
1) JS running in modal mode, so you don't have access to results. It's like use a hammer with closed eyes. Where and how the hammer will strike is unknown.
2) If JS GUI is open, you can't use other useful tools. No STF, no RTP. Impossible to get or check data from workspace.
For example, if you need to enter some coordinate to GUI: In PCL you can click on the pixel and immediate see result in RTP or in the image directly. In JS you should write the coordinate on paper, run JS, then enter manually, run JS( close the GUI ) and check result via blinking or undo/redo.

So, JS is not convenient, but JS can run on any OS without additional code manipulation.

Best regards,
Nikolay.

ADD: v 1.2.0 build 2
+ Generate Defective List by mouse click on image. How to use: Select defect type(Row/Col) and click in image to readout coordinates.
But note, there are bug in PixInsight Core 01.07.05.0779, so don't use that readout features in RTP window.
« Last Edit: 2012 March 09 01:00:34 by NKV »

Offline Philippe B.

  • PixInsight Old Hand
  • ****
  • Posts: 399
    • CIEL AUSTRAL
Re: PCL: CosmeticCorrection module
« Reply #39 on: 2012 March 15 03:09:09 »
again, great tool. Worked like a charm on my test image.

Juan, is it possible to have it soon in all platform (OSX 64) maybe in "dev" update ?


Offline troypiggo

  • PixInsight Addict
  • ***
  • Posts: 258
Re: PCL: CosmeticCorrection module
« Reply #40 on: 2012 March 15 03:36:31 »
If someone can let me know the tools to compile, I'll give it a go.

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #41 on: 2012 March 19 01:36:52 »
If someone can let me know the tools to compile, I'll give it a go.
Source code in first post.
I can compile it for Linux and Win.

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: CosmeticCorrection module
« Reply #42 on: 2012 March 19 01:43:53 »
I'll try to compile it for all platforms ASAP. Can we release it as an update?
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline NKV

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 677
Re: PCL: CosmeticCorrection module
« Reply #43 on: 2012 March 19 01:50:21 »
I'll try to compile it for all platforms ASAP. Can we release it as an update?
Yes, this module is ready for release.
Best regards,
Nikolay.

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: PCL: CosmeticCorrection module
« Reply #44 on: 2012 March 19 01:55:14 »
Great! :) Release it via update or update-devel ?
Juan Conejero
PixInsight Development Team
http://pixinsight.com/