Author Topic: Gradient Domain Operations, take 6  (Read 28215 times)

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Gradient Domain Operations, take 6
« on: 2011 July 31 07:02:41 »
Hi,

here is the latest release of the GradientDomain module. News:

- The feathering process has been accelerated quite considerably, thanks to hints by Juan. A feathering with radius 50 has been reduced from 20 minutes to just 5 seconds  8) .
- The problems at the border to the global background are gone, see attached screenshot. This was achieved by changing the handling of gradients at the border of images, using the gradients at  the actual border where there are no other images. While it still is possible that problems happen (e.g. in corners between images), it is quite unlikely.
- I added some timing output to be able to identify performance bottlenecks in larger mosaics that testers may try.
- And last but not least, the module comes with decent PIDoc documentation, as should any slightly complex tool  do O:) .

Please note that the module is still beta. Possible areas of improvement:

- No process icon
- No way to cancel the process
- incomplete/non existent progress reporting
- Code review: The whole source would certainly benefit from a thorough code review. I am a believer in code reviews  :angel: .
- speed: the current solver is  3x slower than an FFTW solver. Still, for Harry's NA example, the process runs for only 55 seconds, which is quite acceptable, so we may decide to stick with the current solver. With FFTW, it needs only 25 seconds. Other processes elements also may benefit from some performance aware coding.

And of course, we need much more experience with application to real mosaics. The tests that some of you have done on previous incarnations of this process have been most helpful. Please do not hesitate to report test results and suggest improvments.

Enjoy,
Georg

PS: Juan, feel free to publish compiled versions. The documentation is not contained in the attached tar.gz file due to size issus. Please let me know where to mail it.

 
« Last Edit: 2011 July 31 08:09:52 by georg.viehoever »
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: Gradient Domain Operations, take 6
« Reply #1 on: 2011 July 31 07:51:51 »
Hi Georg,

Compiles nicely on Linux 32/64; starting VMware's Windows virtual machine right now.

A few things:

- You've put a text line to describe the tool on each interface (e.g.: 'allows to merge registered images without any visible seams''). It is customary to avoid this kind of 'inline descriptions' in PixInsight tools. If you really like them then there's no problem, but I recommend removing them for the sake of coherence.

- I cannot revise the code in depth right now, although a quick inspection shows me many areas where we can improve things. The main improvement has already been done with separable convolutions, though. The solver is the next bottleneck; I hope we'll manage to reach the same level you've seen with FFTW --but without FFTW of course. Maybe not 'the fastest of the west' but quite close. This is a matter of time and some work to integrate a good cosine transform in PCL. For now, the tool works very well as it is.

- If you don't mind I'm going to announce availability of this module to all PixInsight users through a massive email. We need a lot of people trying it out.

- Documentation: if the whole thing (compressed PIDoc source code and figure images) is less than five megabytes or so, you can send it to me via email (where I am now I have a quite slow Internet connection). Otherwise feel free to upload it to your account on our server (If you don't have your access data let me know).

- Nice work :)
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: Gradient Domain Operations, take 6
« Reply #2 on: 2011 July 31 07:57:23 »
An additional thing I forgot to mention:

- The default combination mode should be 'overlay' in my opinion. This is the only correct way to merge mosaic images. By averaging, you are altering (improving by an average factor of sqrt(2) for each pair of adjacent mosaic frames) the SNR of the final mosaic only on the overlapped regions. After aggressive stretching and further processing the seams may easily become visible for this reason.
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: Gradient Domain Operations, take 6
« Reply #3 on: 2011 July 31 08:09:29 »
Documentation is on its way via email.
Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: Gradient Domain Operations, take 6
« Reply #4 on: 2011 July 31 09:38:25 »
The module is now compiled on Linux 32/64 and Windows 32/64, and I am preparing the update-devel release.

I cannot have access to a Mac machine until September. So we need a volunteer with a Mac machine ready to compile Georg's source code for Mac OS X. Then if he/she sends me the -pxm.dylib files (32 and 64-bit versions), I'll publish them also through update-devel.

So we need a Mac OS X PI/PCL developer.  ???
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: Gradient Domain Operations, take 6
« Reply #5 on: 2011 July 31 13:33:39 »
Hi

Brilliant stuff   :police:

Can't wait to have a go  :D

All PI users owe you a huge Bottle of wine  ;D

Many Thanks Harry
Harry Page

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: Gradient Domain Operations, take 6
« Reply #6 on: 2011 July 31 15:55:57 »
The module is now compiled on Linux 32/64 and Windows 32/64, and I am preparing the update-devel release.

I cannot have access to a Mac machine until September. So we need a volunteer with a Mac machine ready to compile Georg's source code for Mac OS X. Then if he/she sends me the -pxm.dylib files (32 and 64-bit versions), I'll publish them also through update-devel.

So we need a Mac OS X PI/PCL developer.  ???

i might be able to do this. where is the source? i have not been following the threads that carefully.

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: Gradient Domain Operations, take 6
« Reply #7 on: 2011 July 31 23:28:11 »
The source as attached to the first message in this thread http://pixinsight.com/forum/index.php?topic=3295.msg22678#msg22678 .
Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: Gradient Domain Operations, take 6
« Reply #8 on: 2011 August 01 11:11:53 »
Hi

Had a quick go and works very well  ;D

The average setting seems to give a slightley better result than the overlay ? when the star is at a edge

Regards Harry

Harry Page

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: Gradient Domain Operations, take 6
« Reply #9 on: 2011 August 01 13:22:56 »
The average setting seems to give a slightley better result than the overlay ? when the star is at a edge
 Harry

That's right. It's because the averaging reduces the differences at both sides of the seam. Feathering (->Feather radius parameter) should be even more effective to reduce those issues.

Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729
Re: Gradient Domain Operations, take 6
« Reply #10 on: 2011 August 02 08:28:29 »
The source as attached to the first message in this thread http://pixinsight.com/forum/index.php?topic=3295.msg22678#msg22678 .
Georg

okay, thanks. there have been a lot of threads for this module and i wanted to be absolutely sure i got the right one.

sorry i did not see this sooner, i don't know why your replies did not show up in my "unread posts since last visit" until now.

Offline pfile

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 4729

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: Gradient Domain Operations, take 6
« Reply #12 on: 2011 August 14 10:25:58 »
Hi

I have had a good play with this wonderful tool  :-* and can't throw it yet

It would be nice if I could select " views " rather than files , just a bit more friendly


Harry
Harry Page

Offline georg.viehoever

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2132
Re: Gradient Domain Operations, take 6
« Reply #13 on: 2011 August 14 11:55:04 »
Well, it is a good sign when people begin asking for creature comforts, isn't it?
Georg
Georg (6 inch Newton, unmodified Canon EOS40D+80D, unguided EQ5 mount)

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: Gradient Domain Operations, take 6
« Reply #14 on: 2011 August 15 13:42:16 »
Hi

A video of the masters work  8)

http://www.harrysastroshed.com/Mosaic.html


Harry
Harry Page