Author Topic: AutoSTF crashes, likely LGRBCombination problem  (Read 4865 times)

Offline bitli

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 513
AutoSTF crashes, likely LGRBCombination problem
« on: 2010 May 15 23:37:25 »
Hello,

I have a case of STF crashing PI when doing an AUTO on a small image. This is systematic with that image (unfortunately even compressed it is larger than 192KB). The image was produced by the LRGB combination, using the RGB as a target, replacing only L, then doing an Apply Global.
When I do an 'drag of new instance' to the target, the resulting image can be STFed normally.

So I suspect that the LRGB combination does not produce a correct image if apply global is used. The work around is obvious, however it should not create an image that crashes PI.

If required I can mail the images (about 1MB).

-- bitli

Offline bitli

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 513
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #1 on: 2010 May 17 12:25:39 »
To be more precise, PI does not crash, it goes to an endless loop and I have to kill it. This is on Windows 7 64 bits with a 4 core cpu.

-- bitli

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #2 on: 2010 May 17 15:10:51 »
Do you have any pixel that reads "NAN"?
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline bitli

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 513
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #3 on: 2010 May 17 22:11:22 »
I have put the crashing file as well as the two files used to build it in
http://lugrin.ch/astro/images/CrashAutoStf.zip
for a limited time.

There are values listed as 1.#QNB, what ever that is.

-- bitli

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #4 on: 2010 May 18 00:59:57 »
Hi bitli,

Thank you for uploading the images. They have allowed me to identify the problem perfectly.

You have now a record in the history of PixInsight bug tracking: you have discovered three bugs for the price of one  8)

- LRGBCombination should not allow you to generate an image if you don't select existent (and valid) L, R, G and B source images.

- LRGBCombination is using garbage data (arbitrary data gathered from your computer's memory) to form a RGB image. The core application should detect out-of-range and NAN values and fix them.

- ScreenTransferFunction should not crash in presence of NAN (not-a-number) values (which M$ denotes as "1.#QNB" for some exotic reason).

More work for 1.6.1. Sweet! ;D
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #5 on: 2010 May 18 02:24:25 »
Quote
(which M$ denotes as "1.#QNB" for some exotic reason)

Juan,

I have been seeing this on the new (beta) "ReadPSF" module, and was wondering what was the cause of these 'illegal value' representations !!

What are you referring to by <<M$>> - is this Micro$oft ?!!?

Cheers,
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #6 on: 2010 May 18 03:55:25 »
Hi Niall,

Quote
What are you referring to by <<M$>> - is this Micro$oft ?!!?

What's making you think that? ;D
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline bitli

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 513
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #7 on: 2010 May 18 04:04:21 »
When you are at it, can you check if droping a monochrome stf instance on an histogram work? It seems to me that it does not work (it works for color sourcrs...)
-- bitli

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: AutoSTF crashes, likely LGRBCombination problem
« Reply #8 on: 2010 May 18 11:05:40 »
Quote
I have been seeing this on the new (beta) "ReadPSF" module, and was wondering what was the cause of these 'illegal value' representations !!

Oh. This is done by a zero division :P I need to add a routine to calculate a "internal" threshold if it is set as zero (defined by the sample radius).
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com