Author Topic: [Unofficial] New Module: Sharpen  (Read 20128 times)

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #15 on: 2009 September 16 18:25:45 »
Hmmm... I though that I fixed the 8 ways filters :P I was receiving a memory violation when a non integer radius was set. Was this the case? (maybe I uploaded an earlier compilation).


Thanks Carlos for your words :)


Harry, if you have any suggestion on simple processes that are worth implementing, just say so, and I'll add it to my To-do list. I like these simple tools, because I'm a bit rusty and need some previous "exercises" to get into my "programing shape" :D


 
BTW, I don't have a W94 computer... so I cannot help there... I'm counting on Juan's aid here ;)
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #16 on: 2009 September 17 05:35:23 »
Ok. I got the same message now, with any radius. Hmmmmmmmmmmm. Back to the debugger table :P
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Nocturnal

  • PixInsight Jedi Council Member
  • *******
  • Posts: 2727
    • http://www.carpephoton.com
Re: [Unofficial] New Module: Sharpen
« Reply #17 on: 2009 September 17 07:05:58 »
Hi,

I compiled the Sharpen module for x64:

http://www.tungstentech.com/files/Sharpen-pxm-win64.zip
Best,

    Sander
---
Edge HD 1100
QHY-8 for imaging, IMG0H mono for guiding, video cameras for occulations
ASI224, QHY5L-IIc
HyperStar3
WO-M110ED+FR-III/TRF-2008
Takahashi EM-400
PIxInsight, DeepSkyStacker, PHD, Nebulosity

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: [Unofficial] New Module: Sharpen
« Reply #18 on: 2009 September 17 13:13:19 »
Hi Sander

Many thanks for your skilled work, but I am afraid its still bugged >:D

Regards Harry
Harry Page

Offline Nocturnal

  • PixInsight Jedi Council Member
  • *******
  • Posts: 2727
    • http://www.carpephoton.com
Re: [Unofficial] New Module: Sharpen
« Reply #19 on: 2009 September 17 13:18:50 »
Luckily I did not attempt to fix any bugs. I just recompiled :)
Best,

    Sander
---
Edge HD 1100
QHY-8 for imaging, IMG0H mono for guiding, video cameras for occulations
ASI224, QHY5L-IIc
HyperStar3
WO-M110ED+FR-III/TRF-2008
Takahashi EM-400
PIxInsight, DeepSkyStacker, PHD, Nebulosity

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: [Unofficial] New Module: Sharpen
« Reply #20 on: 2009 September 17 13:21:40 »
Hi Carlos

I would like a heal tool !  great for zapping hot pixels, I know there is a clone tool , but a heal tool ( Sorry photoshop talk ) gives a seamless fix  O:)

And how about a dust bunny eradicator  ( This might be hard )

Also there was a hint but real time view of the sharpen tool

And ...........   no I will stop there as I will drive you mad


Harry
Harry Page

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #21 on: 2009 September 17 23:28:52 »
I gave the code a quick look, but did not find that little $!"ยท$ bug :D I fear that I'll have a "nice" day ahead tomorrow, polishing my hunting skills :D


Harry, I'm thinking about that heal tool. I guess that it should not be that hard, working over the clone stamp code (although it is quite complex for me). Perhaps a simple statistical analysis may do the work, like I do in ABE's inner rejection algorithm. Another option is just a simple threshold. My problem is that either way the stars have small chances to survive, so I want to sophisticate that a bit.
What is a dust bunny? The artifact created by dust over the sensor? Sounds interesting... Maybe a FFT approach... :)
About RT, this kind of objects fly more than a pair of meters above my head :D I'll need Juan's help there.

Well, let's see what happens this weekend... :)

Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #22 on: 2009 September 18 10:08:05 »
I think I cornered him... at least, how to reproduce the error, and where it is NOT on the code :D The error appear only when working with floating points images, with the Laplace8 and WeightedLaplace8 algorithm. The answer seems straightforward then, but all algorithms share the same way of handling image bit depth, what is done at the beggining. So, I'm not sure of the reason of this strange behavior. I noticed no problems at all with integer samples...
Also there is something else that is annoying me. If there is no error message, the output is not always the same. I got some "hot" pixels (or even lines), randomly.

Juan, could you give me a hand here?
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: [Unofficial] New Module: Sharpen
« Reply #23 on: 2009 September 18 10:46:34 »
Hi Carlos,

Sure thing. However I ask for a bit of patience since right now I am involved in a huge mess - I am switching from VMware to VirtualBox, and this means I have to rebuild all Windows virtual machines. PixInsight's build system is "under construction" right now on all platforms 8) (non-developer users: the situation is under control -- reasonably ;D)
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
Re: [Unofficial] New Module: Sharpen
« Reply #24 on: 2009 September 18 10:49:01 »
Carlos, one more thing. Could you please upload your source code as a .zip archive? Currently tar is something too exotic for my Linux box  :cheesy:
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #25 on: 2009 September 18 10:54:04 »
Ok. Let me finish some changes I'm doing to GaussianBlur (more parameters and a control window drawing the filter), and I'll upload both modules/codes. Sharpen has some minor changes too, mainly small optimizations of the code.
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Harry page

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1458
    • http://www.harrysastroshed.com
Re: [Unofficial] New Module: Sharpen
« Reply #26 on: 2009 September 18 11:29:38 »
Hi Carlos

Looks like you are having fun   >:D

You are right a dust Bunnie is the shadow from a bit of muck,

I think there are two way of looking at this ,  try and model the mote and correct it, this would be very advanced and perhaps to much to ask or just look the motes in background areas and fix them with a fancy heal tool
Of course you may have many better ideas

Good luck with the hunt  ;D

Harry
Harry Page

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #27 on: 2009 September 18 11:51:55 »
Hi Harry

Yes, I'm thinking on a way to modelate them, automatically. Since it is a multiplicative effect, and with a somehow predictable shape (well, we know that it is very simetrical, and that is a "negative" effect. I've got two candidates to explore: fourier transform and homomorphic transform. Don't expect a quick answer, anyway :) First I want to finish/update other older modules I wrote but were not released.
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #28 on: 2009 September 18 12:49:54 »
Juan (and anybody who wants to join the safari) , I just uploaded the last source code, compressed with zip format:

http://pteam.pixinsight.com/carlos/modules/Sharpen-src-2009-09-18.zip


Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com

Offline Carlos Milovic

  • PTeam Member
  • PixInsight Jedi Master
  • ******
  • Posts: 2172
  • Join the dark side... we have cookies
    • http://www.astrophoto.cl
Re: [Unofficial] New Module: Sharpen
« Reply #29 on: 2009 September 22 05:11:21 »
Hi all

I've updated the links above with the last release. Thanks to Juan's suggestions, I made it much more faster and robust, and it seems that the annoying bug is gone.
Regards,

Carlos Milovic F.
--------------------------------
PixInsight Project Developer
http://www.pixinsight.com