Author Topic: 3D star profile / Perfil estelar en 3D (BETA)  (Read 26803 times)

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
3D star profile / Perfil estelar en 3D (BETA)
« Reply #15 on: 2009 April 10 11:28:12 »
A few quick modifications:

- The script can now be aborted by the user. So a size warning/error is no longer needed (IMO).

- The script shows progress information on the console.

- The perspective transformation points are now calculated faster. See changes in the CreatePerspective function (line 44).

- The MTF transformation is now carried out using a HistogramTransformation instance on a temporary copy of the working image. See the ApplyMTF function (line 73).

Code: [Select]
#include <pjsr/UndoFlag.jsh>
#include <pjsr/FillRule.jsh>
#include <pjsr/ColorSpace.jsh>

// Creates the parameters object.
function DefaultParams()
{
   var params={};
   params.angle = 30;   // Perspective angle in degrees
   params.scaleXY = 6;  // Scale factor for X and Y axis
   params.scaleZ = 500; // Scale factor for Z axis
   params.mtf=0.1;      // Midtones transfer value (0,1)
   params.backgroundColor=0xff403000;
   params.polygonFill=0xffffffff;
   params.polygonBorder=0x10000000;
   params.useShading=true; // Apply shading effect
   params.lightBrightness=700; // Light intensity for the shading effect

   // Precalculated sin and cos of angle
   params.sin_angle=Math.sin(params.angle*Math.PI/180);
   params.cos_angle=Math.cos(params.angle*Math.PI/180);
   return params;
}

// Perspective transformation -- Replaced by faster inline code; see below
/*
function Perspective(x, y, z, params)
{
   with(params){
      // x
      var new_x = (x - ys) * scaleXY;

      // y
      var new_y = ycs - scaleZ * z;

      // z
      new_y -= scaleZ * z; // -----> ???
   }
   return new Point (new_x, new_y);
}
*/

// Applies the perspective transformation to all the pixels in the image
function CreatePerspective(src, limits, perspecParams)
{
   src.initializeStatus( "Computing 3D coordinates", src.height );

   // Calculates the coordinates of each pixel applying the perspective transformation
   var xform=[];
   limits.left=limits.top=1e10;
   limits.right=limits.bottom=-1e10;
   for (var y = 0; y < src.height; y++) {
      xform[y]=[];
      var ys = y * perspecParams.sin_angle;
      var ycs = y * perspecParams.cos_angle * perspecParams.scaleXY;
      for (var x = 0; x < src.width; x++) {
         var z = src.sample( x, y );
         var pixel = new Point( (x - ys)*perspecParams.scaleXY,
                                ycs - perspecParams.scaleZ*z );
         //Perspective(x, ys, ycs, src.sample(x,y), perspecParams);
         xform[y][x]=pixel;
         if(pixel.x<limits.left)   limits.left=pixel.x;
         if(pixel.x>limits.right)  limits.right=pixel.x;
         if(pixel.y<limits.top)    limits.top=pixel.y;
         if(pixel.y>limits.bottom) limits.bottom=pixel.y;
      }

      src.advanceStatus( 1 );
   }
   return xform;
}

function ApplyMTF(src, mtf)
{
   // Faster solution using a process instance
   var HT = new HistogramTransformation;
   with ( HT )
   {
      H = // c0, m, c1, r0, r1
      [[0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, mtf, 1, 0, 1],
       [0, 0.5, 1, 0, 1]];
   }

   var wtmp = new ImageWindow( 1, 1, 1, 16, false, src.colorSpace != ColorSpace_Gray );
   var v = wtmp.mainView;

   v.beginProcess( UndoFlag_NoSwapFile );
   v.image.assign( src );
   v.endProcess();

   HT.executeOn( v, false ); // no swap file
   src.assign( v.image );

   wtmp.close();

   /*
   // Calculates the coordinates of each pixel applying the perspective transformation
   for (var y = 0; y < src.height; y++)
      for (var x = 0; x < src.width; x++){
         var z=Math.mtf(mtf,src.sample(x,y));
         src.setSample(z,x,y);
      }
   */
}

function DieError(message)
{
   var msgb = new MessageBox(message,"Error generating 3D view");
   msgb.execute();
   throw Error( message );
}

function main()
{
   if (ImageWindow.activeWindow.currentView.isNull)
      DieError("There is not an active image");
   /*
   if(ImageWindow.activeWindow.currentView.image.width>500 ||
      ImageWindow.activeWindow.currentView.image.height>500)
         DieError("The image is bigger than 500x500 pixels");*/

   console.show();
   console.writeln( "<end><cbr><br>***** 3D Profiling Script *****" );
   console.flush();

   var startts = new Date;

   // Extract the luminance of the source image
   var src = new Image();
   ImageWindow.activeWindow.currentView.image.extractLuminance(src);

   // Inits the parameters
   var perspecParams = DefaultParams();

   // Apply a midtones transformation
   if ( perspecParams.mtf != 0.5 )
      ApplyMTF(src, perspecParams.mtf);

   // Allow the user to abort this script
   console.abortEnabled = true;

   // Allow status monitoring for our working image
   src.statusEnabled = true;

   // Create the perspective
   var limits = new Rect;
   var xform = CreatePerspective(src,limits,perspecParams);
   //with(limits) console.writeln(format("%f %f %f %f",left,top,right,bottom));

   // Create the output window
   var w = new ImageWindow (Math.round(limits.width), Math.round(limits.height), 3, 8, false, true, '_3dplot');
   var v = w.currentView;
   var i = v.image;

   // Start of the process
   var bmp = new Bitmap (i.width, i.height);
   var g = new Graphics (bmp);

   // Applies a translation to the graphics to center the image
   g.translateTransformation(-limits.left,-limits.top);

   src.initializeStatus( "Rendering 3D profile", src.height-1 );

   v.beginProcess(UndoFlag_NoSwapFile);
      bmp.fill (perspecParams.backgroundColor);
      g.pen =  new Pen (perspecParams.polygonBorder);
      var fillbrush=[];
      if(perspecParams.useShading){
         for(var c=0; c<256;++c)
            fillbrush[c]=new Brush(0xFF000000 | (c<<16) | (c<<8) | c);
      }else
         g.brush = new Brush (perspecParams.polygonFill);

      // Paint the polygons from back to front
      for (var n = 0; n < src.height-1; n++) {
         for (var m = 0; m < src.width-1; m++) {
            if(perspecParams.useShading){
               var slope=src.sample(m,n)-src.sample(m+1,n)+
                         src.sample(m,n+1)-src.sample(m+1,n+1);
               var color=Math.round(slope * perspecParams.lightBrightness + 128);
               color=Math.max(0,Math.min(255,color));
               g.brush=fillbrush[color];
            }
           
            var polygon=new Array(
               xform[n][m],
               xform[n][m+1],
               xform[n+1][m+1],
               xform[n+1][m]);
            g.drawPolygon (polygon);
         }

         src.advanceStatus( 1 );
      }
      g.end();
      i.blend (bmp);
   v.endProcess();
   w.show();
   
   var endts = new Date;
   console.writeln(format ("<br />3D view: %.2f s",(endts.getTime() - startts.getTime()) / 1000));
}

main();
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline David Serrano

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 503
3D star profile / Perfil estelar en 3D (BETA)
« Reply #16 on: 2009 April 10 11:49:48 »
Quote from: "Andres.Pozo"
I have added an optional shading effect:


Diossss qué bueno!!! xD

I've seen you removed the parameter "alt" I had in my original script. It was meant to be a configurable value that indicated the altitude over the terrain, indicated in degress. Thus, a value of 0 would render the grid as if we were on the ground (untested!) and a value of 90 would give a 2D grid.


Quote from: "Andres.Pozo"
Code: [Select]
        return ShowError("The image is bigger than 500x500 pixels");


I agree with Juan on this. The image dimensions limit I suggested was meant to be some kind of "Are you sure?" dialog, to avoid someone ;) asking for a higher limit. I like to allow users to crash their machine if they want to. Detecting the amount of RAM in the system would be useful to make the limit dynamic.

I would implement it as an absolute number of pixels (width * height), thus allowing the user to plot a 2000x10 image.


Quote from: "Andres.Pozo"
Of course, the original idea is of David Serrano and he should be who granted the permission.


The idea may be mine, but at this point the code is yours ;).
--
 David Serrano

Offline Andres.Pozo

  • PTeam Member
  • PixInsight Padawan
  • ****
  • Posts: 927
3D star profile / Perfil estelar en 3D (BETA)
« Reply #17 on: 2009 April 10 13:23:34 »
I have merged the improvements of Juan in the code that I was writting. I also have implemented the visualization using false color mapping the height to a color palette.

Example of false color with shading:


Example of false color without shading:


Code: [Select]
#include <pjsr/UndoFlag.jsh>
#include <pjsr/FillRule.jsh>
#include <pjsr/ColorSpace.jsh>

// Creates the parameters object.
function DefaultParams()
{
   var params={};
   params.angle = 30;   // Perspective angle in degrees
   params.scaleXY = 6;  // Scale factor for X and Y axis
   params.scaleZ = 500; // Scale factor for Z axis
   params.mtf=0.1;      // Midtones transfer value (0,1)
   params.backgroundColor=0xff403000;
   params.polygonFill=0xffffffff;
   params.polygonBorder=0x80000000;
   params.useShading=true; // Apply shading effect
   params.lightBrightness=2000; // Light intensity for the shading effect
   params.palette = [ [0x80,0,0] , [0,0x80,0] , [0,0,0xC0], [0x80,0,0x80], [0x80,0x80,0], [0x80,0x80,0x80] ];
   
   // Precalculated sin and cos of angle
   params.sin_angle=Math.sin(params.angle*Math.PI/180);
   params.cos_angle=Math.cos(params.angle*Math.PI/180);
   return params;
}

// Applies the perspective transformation to all the pixels in the image
function CreatePerspective(src, limits, perspecParams)
{
   src.initializeStatus( "Computing 3D coordinates", src.height );

   // Calculates the coordinates of each pixel applying the perspective transformation
   var xform=[];
   limits.left=limits.top=1e10;
   limits.right=limits.bottom=-1e10;
   for (var y = 0; y < src.height; y++) {
      xform[y]=[];
      var ys = y * perspecParams.sin_angle;
      var ycs = y * perspecParams.cos_angle * perspecParams.scaleXY;
      for (var x = 0; x < src.width; x++){
         var z= src.sample(x,y);
         var pixel=new Point( (x - ys)*perspecParams.scaleXY,
                                ycs - perspecParams.scaleZ*z );
         xform[y][x]=pixel;
         if(pixel.x<limits.left)   limits.left=pixel.x;
         if(pixel.x>limits.right)  limits.right=pixel.x;
         if(pixel.y<limits.top)    limits.top=pixel.y;
         if(pixel.y>limits.bottom) limits.bottom=pixel.y;
      }
      src.advanceStatus( 1 );
   }
   return xform;
}

function ApplyMTF(src, mtf)
{
   // Faster solution using a process instance
   var HT = new HistogramTransformation;
   with ( HT )
   {
      H = // c0, m, c1, r0, r1
      [[0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, mtf, 1, 0, 1],
       [0, 0.5, 1, 0, 1]];
   }

   var wtmp = new ImageWindow( 1, 1, 1, 16, false, src.colorSpace != ColorSpace_Gray );
   var v = wtmp.mainView;

   v.beginProcess( UndoFlag_NoSwapFile );
   v.image.assign( src );
   v.endProcess();

   HT.executeOn( v, false ); // no swap file
   src.assign( v.image );

   wtmp.close();
}

function DieError(message)
{
   var msgb=new MessageBox(message,"Error generating 3D view");
   msgb.execute();
   throw Error( message );
}

function ApplyLighting(basecolor, light)
{
   var r=(basecolor[0]*light/1000);
   r=r>255?255:r;
   var g=(basecolor[1]*light/1000);
   g=g>255?255:g;
   var b=(basecolor[2]*light/1000);
   b=b>255?255:b;
   return 0xFF000000 | (r<<16)| (g<<8) | b;
}

function RenderImage(src,i,limits,xform,perspecParams)
{
   // Start of the process
   var bmp = new Bitmap (i.width, i.height);
   var g = new Graphics (bmp);
   g.antialiasing=true;

   // Applies a translation to the graphics to center the image
   g.translateTransformation(-limits.left,-limits.top);

   bmp.fill (perspecParams.backgroundColor);

   var fillbrush=[];
   if(!perspecParams.useShading){
      for(var c=0;c<perspecParams.palette.length;c++)
         fillbrush[c]=new Brush(0xFF000000 | (perspecParams.palette[c][0]<<16) | (perspecParams.palette[c][1]<<8) | perspecParams.palette[c][2]);
      g.pen =  new Pen (perspecParams.polygonBorder,0);
   } else
      // Using shading the polygon borders should be less visible
      g.pen =  new Pen ((perspecParams.polygonBorder&0x00FFFFFF) | 0x20000000);

   // The median of the source image is the level of the "floor" of the 3D image
   var stats = new ImageStatistics;
   stats.generate(src);
   var minz=stats.median;

   src.initializeStatus( "Rendering 3D profile", src.height-1 );
   // Paint the polygons from back to front
   for (var n = 0; n < src.height-1; n++) {
      for (var m = 0; m < src.width-1; m++) {
         var  z1=src.sample(m,n),
              z2=src.sample(m+1,n),
              z3=src.sample(m,n+1),
              z4=src.sample(m+1,n+1);

         // Get the palette index
         //var z=(z1+z2+z3+z4)/4;
         var z=Math.max(Math.max(z1,z2),Math.max(z3,z4));
         z=(z-minz)/(1-minz); //rescale for mapping the palete to (minz,1)
         var palidx=Math.round(z*perspecParams.palette.length);
         palidx=palidx<0 ? 0 : (palidx>=perspecParams.palette.length ? perspecParams.palette.length-1 : palidx);

         if(perspecParams.useShading){
            // Get the lighting factor
            var slope=z1-z2+z3-z4;
            var lighting=(slope+0.5)*perspecParams.lightBrightness;
            lighting=lighting<0 ? 0 : Math.round(lighting);

            g.brush=new Brush(ApplyLighting(perspecParams.palette[palidx], lighting));
         } else
            g.brush=fillbrush[palidx];

         var polygon=new Array(
            xform[n][m],
            xform[n][m+1],
            xform[n+1][m+1],
            xform[n+1][m]);
         g.drawPolygon (polygon);
      }
      src.advanceStatus( 1 );
   }
   g.end();
   i.blend (bmp);
}

function main()
{
   if(ImageWindow.activeWindow.currentView.isNull)
      return DieError("There is not an active image");

   console.show();
   console.writeln( "<end><cbr><br>***** 3D Profiling Script *****" );
   console.flush();

   var startts = new Date;

   // Extract the luminance of the source image
   var src =new Image();
   ImageWindow.activeWindow.currentView.image.extractLuminance(src);

   // Inits the parameters
   var perspecParams=DefaultParams();

   if( perspecParams.mtf!=0.5)
      ApplyMTF(src, perspecParams.mtf);

   // Allow the user to abort this script
   console.abortEnabled = true;

   // Allow status monitoring for our working image
   src.statusEnabled = true;

   // Create the perspective
   var limits=new Rect;
   var xform=CreatePerspective(src,limits,perspecParams);
   //with(limits) console.writeln(format("%f %f %f %f",left,top,right,bottom));

   // Create the output window
   var newid;
   if(ImageWindow.activeWindow.currentView.isPreview)
      newid=ImageWindow.activeWindow.mainView.id+'_'+ImageWindow.activeWindow.currentView.id+'_3dplot';
   else
      newid=ImageWindow.activeWindow.currentView.id+'_3dplot';
   var w = new ImageWindow (Math.round(limits.width), Math.round(limits.height), 3, 8, false, true, newid);
   try{
      var v = w.currentView;
      var i = v.image;

      v.beginProcess(UndoFlag_NoSwapFile);
      RenderImage(src,i,limits,xform,perspecParams);
      v.endProcess();

      w.show();

      var endts = new Date;
      console.writeln(format ("<br />3D view: %.2f s",(endts.getTime() - startts.getTime()) / 1000));
   } catch(err)
   {
      w.close();
      console.writeln(err);
   }
}

main();

Offline Nocturnal

  • PixInsight Jedi Council Member
  • *******
  • Posts: 2727
    • http://www.carpephoton.com
3D star profile / Perfil estelar en 3D (BETA)
« Reply #18 on: 2009 April 10 13:29:03 »
Voodoo magic. And I've been programming since I got a ZX-81 too many years ago :) Very impressive.
Best,

    Sander
---
Edge HD 1100
QHY-8 for imaging, IMG0H mono for guiding, video cameras for occulations
ASI224, QHY5L-IIc
HyperStar3
WO-M110ED+FR-III/TRF-2008
Takahashi EM-400
PIxInsight, DeepSkyStacker, PHD, Nebulosity

Offline Andres.Pozo

  • PTeam Member
  • PixInsight Padawan
  • ****
  • Posts: 927
3D star profile / Perfil estelar en 3D (BETA)
« Reply #19 on: 2009 April 11 12:13:27 »
Quote from: "David Serrano"

I've seen you removed the parameter "alt" I had in my original script. It was meant to be a configurable value that indicated the altitude over the terrain, indicated in degress. Thus, a value of 0 would render the grid as if we were on the ground (untested!) and a value of 90 would give a 2D grid.


Hi,

I have reimplemented the possibility of rotating the 3D view. It is implemented using a linear projection matrix so it is quite fast.

These are a couple of screenshots:


Code: [Select]
#include <pjsr/UndoFlag.jsh>
#include <pjsr/FillRule.jsh>
#include <pjsr/ColorSpace.jsh>

// Creates the parameters object.
function DefaultParams()
{
   var params={};
   params.azimut = 30;    // Perspective angle in degrees
   params.elevation = 20; // Perspective elevation angle
   params.scaleXY = 6;    // Scale factor for X and Y axis
   params.scaleZ = 50;   // Scale factor for Z axis
   params.mtf=0.5;        // Midtones transfer value (0,1)
   params.backgroundColor=0xff403000;
   params.polygonFill=0xffffffff;
   params.polygonBorder=0x80000000;
   params.useShading=true; // Apply shading effect
   params.lightBrightness=2000; // Light intensity for the shading effect
   params.palette = [ [0x80,0,0] , [0,0x80,0] , [0,0,0xC0], [0x80,0,0x80], [0x80,0x80,0], [0,0x80,0x80], [0x80,0x80,0x80] ];

   return params;
}

// Applies the perspective transformation to all the pixels in the image
function CreatePerspective(src, limits, perspecParams, minz)
{
   src.initializeStatus( "Computing 3D coordinates", src.height );

   // Calculates the coordinates of each pixel applying the perspective transformation
   var xform=[];
   limits.left=limits.top=1e10;
   limits.right=limits.bottom=-1e10;

   // Modify the zscale in order to normalize the peak height
   // when the mtf changes
   var zscale=perspecParams.scaleZ/(1-minz);

   // Projection matrix
   var alpha=Math.rad(90-perspecParams.elevation);
   var beta=Math.rad(perspecParams.azimut);
   var m00=Math.cos(beta);
   var m10=-Math.sin(beta);
   var m20=0;
   var m01=Math.cos(alpha)*Math.sin(beta);
   var m11=Math.cos(alpha)*Math.cos(beta);
   var m21=-Math.sin(alpha);

   for (var y = 0; y < src.height; y++) {
      xform[y]=[];
      for (var x = 0; x < src.width; x++){
         var z= src.sample(x,y)*zscale;
         var pixel=new Point( (m00*x+m10*y)*perspecParams.scaleXY,
                              (m01*x+m11*y+m21*z)*perspecParams.scaleXY );
         xform[y][x]=pixel;
         if(pixel.x<limits.left)   limits.left=pixel.x;
         if(pixel.x>limits.right)  limits.right=pixel.x;
         if(pixel.y<limits.top)    limits.top=pixel.y;
         if(pixel.y>limits.bottom) limits.bottom=pixel.y;
      }
      src.advanceStatus( 1 );
   }
   
   return xform;
}

function ApplyMTF(src, mtf)
{
   // Faster solution using a process instance
   var HT = new HistogramTransformation;
   with ( HT )
   {
      H = // c0, m, c1, r0, r1
      [[0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, mtf, 1, 0, 1],
       [0, 0.5, 1, 0, 1]];
   }

   var wtmp = new ImageWindow( 1, 1, 1, 16, false, src.colorSpace != ColorSpace_Gray );
   var v = wtmp.mainView;

   v.beginProcess( UndoFlag_NoSwapFile );
   v.image.assign( src );
   v.endProcess();

   HT.executeOn( v, false ); // no swap file
   src.assign( v.image );

   wtmp.close();
}

function DieError(message)
{
   var msgb=new MessageBox(message,"Error generating 3D view");
   msgb.execute();
   throw Error( message );
}

function ApplyLighting(basecolor, light)
{
   var r=(basecolor[0]*light/1000);
   r=r>255?255:r;
   var g=(basecolor[1]*light/1000);
   g=g>255?255:g;
   var b=(basecolor[2]*light/1000);
   b=b>255?255:b;
   return 0xFF000000 | (r<<16)| (g<<8) | b;
}

function RenderImage(src,i,limits,xform,perspecParams,minz)
{
   // Start of the process
   var bmp = new Bitmap (i.width, i.height);
   var g = new Graphics (bmp);
   g.antialiasing=true;

   // Applies a translation to the graphics to center the image
   g.translateTransformation(-limits.left,-limits.top);

   bmp.fill (perspecParams.backgroundColor);

   var fillbrush=[];
   if(!perspecParams.useShading){
      for(var c=0;c<perspecParams.palette.length;c++)
         fillbrush[c]=new Brush(0xFF000000 | (perspecParams.palette[c][0]<<16) | (perspecParams.palette[c][1]<<8) | perspecParams.palette[c][2]);
      g.pen =  new Pen (perspecParams.polygonBorder,0);
   } else
      // Using shading the polygon borders should be less visible
      g.pen =  new Pen ((perspecParams.polygonBorder&0x00FFFFFF) | 0x20000000);

   src.initializeStatus( "Rendering 3D profile", src.height-1 );
   // Paint the polygons from back to front
   for (var n = 0; n < src.height-1; n++) {
      for (var m = 0; m < src.width-1; m++) {
         var  z1=src.sample(m,n),
              z2=src.sample(m+1,n),
              z3=src.sample(m,n+1),
              z4=src.sample(m+1,n+1);

         // Get the palette index
         //var z=(z1+z2+z3+z4)/4;
         var zM=Math.max(Math.max(z1,z2),Math.max(z3,z4));
         var zm=Math.min(Math.min(z1,z2),Math.min(z3,z4));
         var z=(zm+zM)/2;
         z=(z-minz)/(1-minz); //rescale for mapping the palete to (minz,1)
         var palidx=Math.round(z*perspecParams.palette.length);
         palidx=palidx<0 ? 0 : (palidx>=perspecParams.palette.length ? perspecParams.palette.length-1 : palidx);

         if(perspecParams.useShading){
            // Get the lighting factor
            var slope=z1-z2+z3-z4;
            var lighting=(slope+0.5)*perspecParams.lightBrightness;
            lighting=lighting<0 ? 0 : Math.round(lighting);

            g.brush=new Brush(ApplyLighting(perspecParams.palette[palidx], lighting));
         } else
            g.brush=fillbrush[palidx];

         var polygon=new Array(
            xform[n][m],
            xform[n][m+1],
            xform[n+1][m+1],
            xform[n+1][m]);
         g.drawPolygon (polygon);
      }
      src.advanceStatus( 1 );
   }
   g.end();
   i.blend (bmp);
}

function main()
{
   if(ImageWindow.activeWindow.currentView.isNull)
      return DieError("There is not an active image");

   console.show();
   console.writeln( "<end><cbr><br>***** 3D Profiling Script *****" );
   console.flush();

   var startts = new Date;

   // Extract the luminance of the source image
   var src =new Image();
   ImageWindow.activeWindow.currentView.image.extractLuminance(src);

   // Inits the parameters
   var perspecParams=DefaultParams();

   if( perspecParams.mtf!=0.5)
      ApplyMTF(src, perspecParams.mtf);

   // Allow the user to abort this script
   console.abortEnabled = true;

   // Allow status monitoring for our working image
   src.statusEnabled = true;

   // The median of the source image is the level of the "floor" of the 3D image
   var stats = new ImageStatistics;
   stats.generate(src);
   var minz=stats.median;

   // Create the perspective
   var limits=new Rect;
   var xform=CreatePerspective(src,limits,perspecParams,minz);
   //with(limits) console.writeln(format("%f %f %f %f",left,top,right,bottom));

   // Create the output window
   var newid;
   if(ImageWindow.activeWindow.currentView.isPreview)
      newid=ImageWindow.activeWindow.mainView.id+'_'+ImageWindow.activeWindow.currentView.id+'_3dplot';
   else
      newid=ImageWindow.activeWindow.currentView.id+'_3dplot';
   var w = new ImageWindow (Math.round(limits.width), Math.round(limits.height), 3, 8, false, true, newid);
   try{
      var v = w.currentView;
      var i = v.image;

      v.beginProcess(UndoFlag_NoSwapFile);
      RenderImage(src,i,limits,xform,perspecParams,minz);
      v.endProcess();

      w.show();

      var endts = new Date;
      console.writeln(format ("<br />3D view: %.2f s",(endts.getTime() - startts.getTime()) / 1000));
   } catch(err)
   {
      w.close();
      console.writeln(err);
   }
}

main();

Offline David Serrano

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 503
3D star profile / Perfil estelar en 3D (BETA)
« Reply #20 on: 2009 April 11 15:30:12 »
Smooth color transitions. They are somewhat ugly but I don't care about it. The strange profile was caused by a quick Morphological ;):



Differences:

Code: [Select]
--- 3dplot/3dplot-0.7.js 2009-04-11 22:53:11.000000000 +0200
+++ 3dplot/3dplot-0.8.js 2009-04-12 00:32:50.000000000 +0200
@@ -16,6 +16,7 @@
    params.polygonBorder=0x80000000;
    params.useShading=true; // Apply shading effect
    params.lightBrightness=2000; // Light intensity for the shading effect
+   params.palette_elems = 256;
    params.palette = [ [0x80,0,0] , [0,0x80,0] , [0,0,0xC0], [0x80,0,0x80], [0x80,0x80,0], [0,0x80,0x80], [0x80,0x80,0x80] ];
 
    return params;
@@ -108,6 +109,33 @@
    return 0xFF000000 | (r<<16)| (g<<8) | b;
 }
 
+// the resulting palette doesn't have to be exactly 'num' elements long.
+function ExpandPalette(params)
+{
+   var p = params.palette;
+   var num = params.palette_elems;
+   var expanded = new Array;
+   var steps = Math.round (num / p.length);  // steps between two provided palette elements
+
+   for (var c = 0; c < p.length - 1; c++) {
+      var from = p[c];
+      var to = p[c+1];
+      var step_red   = (to[0] - from[0]) / steps;
+      var step_green = (to[1] - from[1]) / steps;
+      var step_blue  = (to[2] - from[2]) / steps;
+      for (s = 0; s < steps; s++) {
+         var new_red   = from[0] + s * step_red;
+         var new_green = from[1] + s * step_green;
+         var new_blue  = from[2] + s * step_blue;
+         expanded.push ([ new_red, new_green, new_blue ]);
+      }
+   }
+   // add last user-supplied palette element
+   expanded.push (p[p.length-1]);
+
+   params.palette = expanded;
+}
+
 function RenderImage(src,i,limits,xform,perspecParams,minz)
 {
    // Start of the process
@@ -120,6 +148,8 @@
 
    bmp.fill (perspecParams.backgroundColor);
 
+   ExpandPalette (perspecParams);
+
    var fillbrush=[];
    if(!perspecParams.useShading){
       for(var c=0;c<perspecParams.palette.length;c++)


Full code:

Code: [Select]
#include <pjsr/UndoFlag.jsh>
#include <pjsr/FillRule.jsh>
#include <pjsr/ColorSpace.jsh>

// Creates the parameters object.
function DefaultParams()
{
   var params={};
   params.azimut = 30;    // Perspective angle in degrees
   params.elevation = 20; // Perspective elevation angle
   params.scaleXY = 6;    // Scale factor for X and Y axis
   params.scaleZ = 50;   // Scale factor for Z axis
   params.mtf=0.5;        // Midtones transfer value (0,1)
   params.backgroundColor=0xff403000;
   params.polygonFill=0xffffffff;
   params.polygonBorder=0x80000000;
   params.useShading=true; // Apply shading effect
   params.lightBrightness=2000; // Light intensity for the shading effect
   params.palette_elems = 256;
   params.palette = [ [0x80,0,0] , [0,0x80,0] , [0,0,0xC0], [0x80,0,0x80], [0x80,0x80,0], [0,0x80,0x80], [0x80,0x80,0x80] ];

   return params;
}

// Applies the perspective transformation to all the pixels in the image
function CreatePerspective(src, limits, perspecParams, minz)
{
   src.initializeStatus( "Computing 3D coordinates", src.height );

   // Calculates the coordinates of each pixel applying the perspective transformation
   var xform=[];
   limits.left=limits.top=1e10;
   limits.right=limits.bottom=-1e10;

   // Modify the zscale in order to normalize the peak height
   // when the mtf changes
   var zscale=perspecParams.scaleZ/(1-minz);

   // Projection matrix
   var alpha=Math.rad(90-perspecParams.elevation);
   var beta=Math.rad(perspecParams.azimut);
   var m00=Math.cos(beta);
   var m10=-Math.sin(beta);
   var m20=0;
   var m01=Math.cos(alpha)*Math.sin(beta);
   var m11=Math.cos(alpha)*Math.cos(beta);
   var m21=-Math.sin(alpha);

   for (var y = 0; y < src.height; y++) {
      xform[y]=[];
      for (var x = 0; x < src.width; x++){
         var z= src.sample(x,y)*zscale;
         var pixel=new Point( (m00*x+m10*y)*perspecParams.scaleXY,
                              (m01*x+m11*y+m21*z)*perspecParams.scaleXY );
         xform[y][x]=pixel;
         if(pixel.x<limits.left)   limits.left=pixel.x;
         if(pixel.x>limits.right)  limits.right=pixel.x;
         if(pixel.y<limits.top)    limits.top=pixel.y;
         if(pixel.y>limits.bottom) limits.bottom=pixel.y;
      }
      src.advanceStatus( 1 );
   }
   
   return xform;
}

function ApplyMTF(src, mtf)
{
   // Faster solution using a process instance
   var HT = new HistogramTransformation;
   with ( HT )
   {
      H = // c0, m, c1, r0, r1
      [[0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, mtf, 1, 0, 1],
       [0, 0.5, 1, 0, 1]];
   }

   var wtmp = new ImageWindow( 1, 1, 1, 16, false, src.colorSpace != ColorSpace_Gray );
   var v = wtmp.mainView;

   v.beginProcess( UndoFlag_NoSwapFile );
   v.image.assign( src );
   v.endProcess();

   HT.executeOn( v, false ); // no swap file
   src.assign( v.image );

   wtmp.close();
}

function DieError(message)
{
   var msgb=new MessageBox(message,"Error generating 3D view");
   msgb.execute();
   throw Error( message );
}

function ApplyLighting(basecolor, light)
{
   var r=(basecolor[0]*light/1000);
   r=r>255?255:r;
   var g=(basecolor[1]*light/1000);
   g=g>255?255:g;
   var b=(basecolor[2]*light/1000);
   b=b>255?255:b;
   return 0xFF000000 | (r<<16)| (g<<8) | b;
}

// the resulting palette doesn't have to be exactly 'num' elements long.
function ExpandPalette(params)
{
   var p = params.palette;
   var num = params.palette_elems;
   var expanded = new Array;
   var steps = Math.round (num / p.length);  // steps between two provided palette elements

   for (var c = 0; c < p.length - 1; c++) {
      var from = p[c];
      var to = p[c+1];
      var step_red   = (to[0] - from[0]) / steps;
      var step_green = (to[1] - from[1]) / steps;
      var step_blue  = (to[2] - from[2]) / steps;
      for (s = 0; s < steps; s++) {
         var new_red   = from[0] + s * step_red;
         var new_green = from[1] + s * step_green;
         var new_blue  = from[2] + s * step_blue;
         expanded.push ([ new_red, new_green, new_blue ]);
      }
   }
   // add last user-supplied palette element
   expanded.push (p[p.length-1]);

   params.palette = expanded;
}

function RenderImage(src,i,limits,xform,perspecParams,minz)
{
   // Start of the process
   var bmp = new Bitmap (i.width, i.height);
   var g = new Graphics (bmp);
   g.antialiasing=true;

   // Applies a translation to the graphics to center the image
   g.translateTransformation(-limits.left,-limits.top);

   bmp.fill (perspecParams.backgroundColor);

   ExpandPalette (perspecParams);

   var fillbrush=[];
   if(!perspecParams.useShading){
      for(var c=0;c<perspecParams.palette.length;c++)
         fillbrush[c]=new Brush(0xFF000000 | (perspecParams.palette[c][0]<<16) | (perspecParams.palette[c][1]<<8) | perspecParams.palette[c][2]);
      g.pen =  new Pen (perspecParams.polygonBorder,0);
   } else
      // Using shading the polygon borders should be less visible
      g.pen =  new Pen ((perspecParams.polygonBorder&0x00FFFFFF) | 0x20000000);

   src.initializeStatus( "Rendering 3D profile", src.height-1 );
   // Paint the polygons from back to front
   for (var n = 0; n < src.height-1; n++) {
      for (var m = 0; m < src.width-1; m++) {
         var  z1=src.sample(m,n),
              z2=src.sample(m+1,n),
              z3=src.sample(m,n+1),
              z4=src.sample(m+1,n+1);

         // Get the palette index
         //var z=(z1+z2+z3+z4)/4;
         var zM=Math.max(Math.max(z1,z2),Math.max(z3,z4));
         var zm=Math.min(Math.min(z1,z2),Math.min(z3,z4));
         var z=(zm+zM)/2;
         z=(z-minz)/(1-minz); //rescale for mapping the palete to (minz,1)
         var palidx=Math.round(z*perspecParams.palette.length);
         palidx=palidx<0 ? 0 : (palidx>=perspecParams.palette.length ? perspecParams.palette.length-1 : palidx);

         if(perspecParams.useShading){
            // Get the lighting factor
            var slope=z1-z2+z3-z4;
            var lighting=(slope+0.5)*perspecParams.lightBrightness;
            lighting=lighting<0 ? 0 : Math.round(lighting);

            g.brush=new Brush(ApplyLighting(perspecParams.palette[palidx], lighting));
         } else
            g.brush=fillbrush[palidx];

         var polygon=new Array(
            xform[n][m],
            xform[n][m+1],
            xform[n+1][m+1],
            xform[n+1][m]);
         g.drawPolygon (polygon);
      }
      src.advanceStatus( 1 );
   }
   g.end();
   i.blend (bmp);
}

function main()
{
   if(ImageWindow.activeWindow.currentView.isNull)
      return DieError("There is not an active image");

   console.show();
   console.writeln( "<end><cbr><br>***** 3D Profiling Script *****" );
   console.flush();

   var startts = new Date;

   // Extract the luminance of the source image
   var src =new Image();
   ImageWindow.activeWindow.currentView.image.extractLuminance(src);

   // Inits the parameters
   var perspecParams=DefaultParams();

   if( perspecParams.mtf!=0.5)
      ApplyMTF(src, perspecParams.mtf);

   // Allow the user to abort this script
   console.abortEnabled = true;

   // Allow status monitoring for our working image
   src.statusEnabled = true;

   // The median of the source image is the level of the "floor" of the 3D image
   var stats = new ImageStatistics;
   stats.generate(src);
   var minz=stats.median;

   // Create the perspective
   var limits=new Rect;
   var xform=CreatePerspective(src,limits,perspecParams,minz);
   //with(limits) console.writeln(format("%f %f %f %f",left,top,right,bottom));

   // Create the output window
   var newid;
   if(ImageWindow.activeWindow.currentView.isPreview)
      newid=ImageWindow.activeWindow.mainView.id+'_'+ImageWindow.activeWindow.currentView.id+'_3dplot';
   else
      newid=ImageWindow.activeWindow.currentView.id+'_3dplot';
   var w = new ImageWindow (Math.round(limits.width), Math.round(limits.height), 3, 8, false, true, newid);
   try{
      var v = w.currentView;
      var i = v.image;

      v.beginProcess(UndoFlag_NoSwapFile);
      RenderImage(src,i,limits,xform,perspecParams,minz);
      v.endProcess();

      w.show();

      var endts = new Date;
      console.writeln(format ("<br />3D view: %.2f s",(endts.getTime() - startts.getTime()) / 1000));
   } catch(err)
   {
      w.close();
      console.writeln(err);
   }
}

main();
--
 David Serrano

Offline Andres.Pozo

  • PTeam Member
  • PixInsight Padawan
  • ****
  • Posts: 927
3D star profile / Perfil estelar en 3D (BETA)
« Reply #21 on: 2009 April 12 02:18:23 »
Quote from: "David Serrano"
Smooth color transitions.


That's a very good idea!!

One warning, the rendering function only works with an azimut angle between 0º an 90º. For different angles the painting of the polygons must be done in a different order.

Also, if the rendering was done painting triangles (instead of 4 vertex polygons) the color transitions and the shading would be smoother. However, the rendering would be also much slower and perhaps the polygon borders should not be drawn.

Offline David Serrano

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 503
3D star profile / Perfil estelar en 3D (BETA)
« Reply #22 on: 2009 April 12 04:54:03 »
Finally, some user interface.

I've given up fighting against NumericControl.slider.setRange, even after reading a thread discussing its usage. The intended interval for the MTF is 0.005 but it jumps from 0.001 to 0.010 when changing the range from [1, 1000] to [1, 1001]. I'd also like the Light brightness to go in steps of 10.

Andrés, do you agree on GPLv3?

Code: [Select]
/*
    3DPlot v0.9
    Iteratively stretch histogram with an appropriate luminance mask each time.
    Copyright (C) 2009  Andrés Pozo, Juan Conejero, David Serrano

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, version 3 of the License.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/

/*
    Changelog:
   0.9:   License, changelog, bare-bones user interface.
   0.8:   Smooth color transitions.
   0.7:   Reimplemented the possibility of rotating the 3D view.
   0.6:   Visualization now maps the height to a color palette.
   0.5:   The script can now be aborted by the user.
          The script shows progress information on the console.
          The perspective transformation points are now calculated faster.
          The MTF transformation is now carried out using a HT.
   0.4:   Optional shading effect added.
   0.3:   The resulting image shows the full extent of the 3D view.
          The code has been reorganized and structured.
          A MTF is applied to the image to improve the visualization.
          The perspective transformation has been simplified again.
          There is a couple of checks before starting the algorithm.
   0.2:   It now works on grayscale images.
          The 3D image is centered in the output image.
          The code is a bit simpler.
          It is now 7 times faster.
   0.1:   Initial test version.
*/

#define VERSION "0.9"

#include <pjsr/ColorSpace.jsh>
#include <pjsr/FillRule.jsh>
#include <pjsr/FrameStyle.jsh>
#include <pjsr/NumericControl.jsh>
#include <pjsr/UndoFlag.jsh>

#feature-id 3DPlot
#feature-info Please write something here.
//#feature-icon 3dplot.xpm

// Creates the parameters object.
function DefaultParams()
{
   this.azimut = 30;    // Perspective angle in degrees
   this.elevation = 20; // Perspective elevation angle
   this.scaleXY = 6;    // Scale factor for X and Y axis
   this.scaleZ = 50;   // Scale factor for Z axis
   this.mtf=0.5;        // Midtones transfer value (0,1)
   this.backgroundColor=0xff403000;
   this.polygonFill=0xffffffff;
   this.polygonBorder=0x80000000;
   this.useShading=true; // Apply shading effect
   this.lightBrightness=2000; // Light intensity for the shading effect
   this.palette_elems = 256;
   this.palette = [ [0x80,0,0] , [0,0x80,0] , [0,0,0xC0], [0x80,0,0x80], [0x80,0x80,0], [0,0x80,0x80], [0x80,0x80,0x80] ];
}
var perspecParams = new DefaultParams;

// Applies the perspective transformation to all the pixels in the image
function CreatePerspective(src, limits, perspecParams, minz)
{
   src.initializeStatus( "Computing 3D coordinates", src.height );

   // Calculates the coordinates of each pixel applying the perspective transformation
   var xform=[];
   limits.left=limits.top=1e10;
   limits.right=limits.bottom=-1e10;

   // Modify the zscale in order to normalize the peak height
   // when the mtf changes
   var zscale=perspecParams.scaleZ/(1-minz);

   // Projection matrix
   var alpha=Math.rad(90-perspecParams.elevation);
   var beta=Math.rad(perspecParams.azimut);
   var m00=Math.cos(beta);
   var m10=-Math.sin(beta);
   var m20=0;
   var m01=Math.cos(alpha)*Math.sin(beta);
   var m11=Math.cos(alpha)*Math.cos(beta);
   var m21=-Math.sin(alpha);

   for (var y = 0; y < src.height; y++) {
      xform[y]=[];
      for (var x = 0; x < src.width; x++){
         var z= src.sample(x,y)*zscale;
         var pixel=new Point( (m00*x+m10*y)*perspecParams.scaleXY,
                              (m01*x+m11*y+m21*z)*perspecParams.scaleXY );
         xform[y][x]=pixel;
         if(pixel.x<limits.left)   limits.left=pixel.x;
         if(pixel.x>limits.right)  limits.right=pixel.x;
         if(pixel.y<limits.top)    limits.top=pixel.y;
         if(pixel.y>limits.bottom) limits.bottom=pixel.y;
      }
      src.advanceStatus( 1 );
   }
   
   return xform;
}

function ApplyMTF(src, mtf)
{
   // Faster solution using a process instance
   var HT = new HistogramTransformation;
   with ( HT )
   {
      H = // c0, m, c1, r0, r1
      [[0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, mtf, 1, 0, 1],
       [0, 0.5, 1, 0, 1]];
   }

   var wtmp = new ImageWindow( 1, 1, 1, 16, false, src.colorSpace != ColorSpace_Gray );
   var v = wtmp.mainView;

   v.beginProcess( UndoFlag_NoSwapFile );
   v.image.assign( src );
   v.endProcess();

   HT.executeOn( v, false ); // no swap file
   src.assign( v.image );

   wtmp.close();
}

function DieError(message)
{
   var msgb=new MessageBox(message,"Error generating 3D view");
   msgb.execute();
   throw Error( message );
}

function ApplyLighting(basecolor, light)
{
   var r=(basecolor[0]*light/1000);
   r=r>255?255:r;
   var g=(basecolor[1]*light/1000);
   g=g>255?255:g;
   var b=(basecolor[2]*light/1000);
   b=b>255?255:b;
   return 0xFF000000 | (r<<16)| (g<<8) | b;
}

// the resulting palette doesn't have to be exactly 'num' elements long.
function ExpandPalette(params)
{
   var p = params.palette;
   var num = params.palette_elems;
   var expanded = new Array;
   var steps = Math.round (num / p.length);  // steps between two provided palette elements

   for (var c = 0; c < p.length - 1; c++) {
      var from = p[c];
      var to = p[c+1];
      var step_red   = (to[0] - from[0]) / steps;
      var step_green = (to[1] - from[1]) / steps;
      var step_blue  = (to[2] - from[2]) / steps;
      for (s = 0; s < steps; s++) {
         var new_red   = from[0] + s * step_red;
         var new_green = from[1] + s * step_green;
         var new_blue  = from[2] + s * step_blue;
         expanded.push ([ new_red, new_green, new_blue ]);
      }
   }
   // add last user-supplied palette element
   expanded.push (p[p.length-1]);

   params.palette = expanded;
}

function RenderImage(src,i,limits,xform,perspecParams,minz)
{
   // Start of the process
   var bmp = new Bitmap (i.width, i.height);
   var g = new Graphics (bmp);
   g.antialiasing=true;

   // Applies a translation to the graphics to center the image
   g.translateTransformation(-limits.left,-limits.top);

   bmp.fill (perspecParams.backgroundColor);

   ExpandPalette (perspecParams);

   var fillbrush=[];
   if(!perspecParams.useShading){
      for(var c=0;c<perspecParams.palette.length;c++)
         fillbrush[c]=new Brush(0xFF000000 | (perspecParams.palette[c][0]<<16) | (perspecParams.palette[c][1]<<8) | perspecParams.palette[c][2]);
      g.pen =  new Pen (perspecParams.polygonBorder,0);
   } else
      // Using shading the polygon borders should be less visible
      g.pen =  new Pen ((perspecParams.polygonBorder&0x00FFFFFF) | 0x20000000);

   src.initializeStatus( "Rendering 3D profile", src.height-1 );
   // Paint the polygons from back to front
   for (var n = 0; n < src.height-1; n++) {
      for (var m = 0; m < src.width-1; m++) {
         var  z1=src.sample(m,n),
              z2=src.sample(m+1,n),
              z3=src.sample(m,n+1),
              z4=src.sample(m+1,n+1);

         // Get the palette index
         //var z=(z1+z2+z3+z4)/4;
         var zM=Math.max(Math.max(z1,z2),Math.max(z3,z4));
         var zm=Math.min(Math.min(z1,z2),Math.min(z3,z4));
         var z=(zm+zM)/2;
         z=(z-minz)/(1-minz); //rescale for mapping the palete to (minz,1)
         var palidx=Math.round(z*perspecParams.palette.length);
         palidx=palidx<0 ? 0 : (palidx>=perspecParams.palette.length ? perspecParams.palette.length-1 : palidx);

         if(perspecParams.useShading){
            // Get the lighting factor
            var slope=z1-z2+z3-z4;
            var lighting=(slope+0.5)*perspecParams.lightBrightness;
            lighting=lighting<0 ? 0 : Math.round(lighting);

            g.brush=new Brush(ApplyLighting(perspecParams.palette[palidx], lighting));
         } else
            g.brush=fillbrush[palidx];

         var polygon=new Array(
            xform[n][m],
            xform[n][m+1],
            xform[n+1][m+1],
            xform[n+1][m]);
         g.drawPolygon (polygon);
      }
      src.advanceStatus( 1 );
   }
   g.end();
   i.blend (bmp);
}

function _3dplot_dialog() {
   this.__base__ = Dialog;
   this.__base__();

   // help label
   this.helpLabel = new Label (this);
   with (this.helpLabel) {
      frameStyle = FrameStyle_Box;
       margin = 4;
       wordWrapping = true;
       useRichText = true;
       text = "<b>3DPlot v"+VERSION+"</b> - A " +
          "script that wants some description.";
   }

   // iterations
   this.azimut_NC = new NumericControl (this);
   with (this.azimut_NC) {
      label.text = "Azimut:";
      setRange (0, 90);
      slider.setRange (0, 90);
      slider.minWidth = 200;
      setPrecision (0);
      setValue (perspecParams.azimut);
      toolTip = "Azimut of view.";
      onValueUpdated = function (value) {
        perspecParams.azimut = value;
      }
   }

   // median
   this.elevation_NC = new NumericControl (this);
   with (this.elevation_NC) {
      label.text = "Elevation over the terrain:";
      setRange (0, 90);
      slider.setRange (0, 90);
      slider.minWidth = 200;
      setPrecision (0);
      setValue (perspecParams.elevation);
      toolTip = "Elevation of the observer over the terrain.";
      onValueUpdated = function (value) {
         perspecParams.elevation = value;
      }
   }

   // scaleXY
   this.scaleXY_NC = new NumericControl (this);
   with (this.scaleXY_NC) {
      label.text = "Scale of X and Y coordinates:";
      setRange (1, 10);
      slider.setRange (1, 10);
      slider.minWidth = 50;
      setPrecision (0);
      setValue (perspecParams.scaleXY);
      toolTip = "Scale of X and Y coordinates.";
      onValueUpdated = function (value) {
         perspecParams.scaleXY = value;
      }
   }

   // scaleZ
   this.scaleZ_NC = new NumericControl (this);
   with (this.scaleZ_NC) {
      label.text = "Scale of Z coordinate:";
      setRange (1, 100);
      slider.setRange (1, 100);
      slider.minWidth = 80;
      setPrecision (0);
      setValue (perspecParams.scaleZ);
      toolTip = "Scale of Z coordinate.";
      onValueUpdated = function (value) {
         perspecParams.scaleZ = value;
      }
   }

   // mtf
   this.mtf_NC = new NumericControl (this);
   with (this.mtf_NC) {
      label.text = "MTF:";
      setRange (0.005, 0.995);
      slider.setRange (1, 990);
      slider.minWidth = 800;
      setPrecision (3);
      setValue (perspecParams.mtf);
      toolTip = "MidtonesTransferFunction to apply in order to improve faint detail visualization.";
      onValueUpdated = function (value) {
         perspecParams.mtf = value;
      }
   }

   // useShading
   this.shading_CB = new CheckBox (this);
   with (this.shading_CB) {
      text = "Use shading";
      checked = perspecParams.useShading;
      onCheck = function (checked) { perspecParams.useShading = checked; }
      toolTip = "Check to toggle the use of shading.";
   }

   // lightBrightness
   this.brightness_NC = new NumericControl (this);
   with (this.brightness_NC) {
      label.text = "Light brightness:";
      setRange (100, 5000);
      slider.setRange (1, 490);
      slider.minWidth = 200;
      setPrecision (0);
      setValue (perspecParams.lightBrightness);
      toolTip = "Intensity of the light.";
      onValueUpdated = function (value) {
         perspecParams.lightBrightness = value;
      }
   }

   // buttons
   this.ok_Button = new PushButton (this);
   this.ok_Button.text = " OK ";
   this.ok_Button.onClick = function() { this.dialog.ok(); };

   this.cancel_Button = new PushButton (this);
   this.cancel_Button.text = " Cancel ";
   this.cancel_Button.onClick = function() { this.dialog.cancel(); };

   this.buttons_Sizer = new HorizontalSizer;
   this.buttons_Sizer.spacing = 4;
   this.buttons_Sizer.addStretch();
   this.buttons_Sizer.add (this.ok_Button);
   this.buttons_Sizer.add (this.cancel_Button);

   // pack everything
   this.sizer = new VerticalSizer;
   with (this.sizer) {
      margin = 6;
      spacing = 6;
      add (this.helpLabel);
      addSpacing (4);
      add (this.azimut_NC);
      add (this.elevation_NC);
      add (this.scaleXY_NC);
      add (this.scaleZ_NC);
      add (this.mtf_NC);
      add (this.shading_CB);
      add (this.brightness_NC);
      add (this.buttons_Sizer);
   }

   this.windowTitle = "3DPlot v" + VERSION;
   this.adjustToContents();
}
_3dplot_dialog.prototype = new Dialog;
var dialog = new _3dplot_dialog;

function main()
{
   if(ImageWindow.activeWindow.currentView.isNull)
      return DieError("There is not an active image");

   if (!dialog.execute())
      return;

   console.show();
   console.writeln( "<end><cbr><br>***** 3D Profiling Script *****" );
   console.flush();

   var startts = new Date;

   // Extract the luminance of the source image
   var src =new Image();
   ImageWindow.activeWindow.currentView.image.extractLuminance(src);

   // Inits the parameters
   //var perspecParams=DefaultParams();

   if( perspecParams.mtf!=0.5)
      ApplyMTF(src, perspecParams.mtf);

   // Allow the user to abort this script
   console.abortEnabled = true;

   // Allow status monitoring for our working image
   src.statusEnabled = true;

   // The median of the source image is the level of the "floor" of the 3D image
   var stats = new ImageStatistics;
   stats.generate(src);
   var minz=stats.median;

   // Create the perspective
   var limits=new Rect;
   var xform=CreatePerspective(src,limits,perspecParams,minz);
   //with(limits) console.writeln(format("%f %f %f %f",left,top,right,bottom));

   // Create the output window
   var newid;
   if(ImageWindow.activeWindow.currentView.isPreview)
      newid=ImageWindow.activeWindow.mainView.id+'_'+ImageWindow.activeWindow.currentView.id+'_3dplot';
   else
      newid=ImageWindow.activeWindow.currentView.id+'_3dplot';
   var w = new ImageWindow (Math.round(limits.width), Math.round(limits.height), 3, 8, false, true, newid);
   try{
      var v = w.currentView;
      var i = v.image;

      v.beginProcess(UndoFlag_NoSwapFile);
      RenderImage(src,i,limits,xform,perspecParams,minz);
      v.endProcess();

      w.show();

      var endts = new Date;
      console.writeln(format ("<br />3D view: %.2f s",(endts.getTime() - startts.getTime()) / 1000));
   } catch(err)
   {
      w.close();
      console.writeln(err);
   }
}

main();
--
 David Serrano

Offline Andres.Pozo

  • PTeam Member
  • PixInsight Padawan
  • ****
  • Posts: 927
3D star profile / Perfil estelar en 3D (BETA)
« Reply #23 on: 2009 April 12 06:30:20 »
Quote from: "David Serrano"
Finally, some user interface.

I've given up fighting against NumericControl.slider.setRange, even after reading a thread discussing its usage. The intended interval for the MTF is 0.005 but it jumps from 0.001 to 0.010 when changing the range from [1, 1000] to [1, 1001]. I'd also like the Light brightness to go in steps of 10.

Andrés, do you agree on GPLv3?



David, the GPLv3 would be fine. However, I think that Juan should be also added to the list of contributors. He added some good optimizations and most of the code for console management.

Offline David Serrano

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 503
3D star profile / Perfil estelar en 3D (BETA)
« Reply #24 on: 2009 April 12 07:22:52 »
Quote from: "Andres.Pozo"
David, the GPLv3 would be fine. However, I think that Juan should be also added to the list of contributors.


Oops, that's true. I've updated the code accordingly ;).
--
 David Serrano

Offline Niall Saunders

  • PTeam Member
  • PixInsight Jedi Knight
  • *****
  • Posts: 1456
  • We have cookies? Where ?
3D star profile / Perfil estelar en 3D (BETA)
« Reply #25 on: 2009 April 12 13:33:57 »
Hi Guys,

Fantastic utility !!

Might I make a suggestion for further, future, development?

Take your basic idea, and code structure, but use it to visualise FWHM of all stars in the image.

Could it be used to visualise star elongation (where FWHM in the X-axis does not equal FWHM in the Y-axis) ?

Could it be used to visualise areas of the image where FWHM is different from the 'median' FWHM?

To me, this sort of approach would allow you to visualise optical abberations such as coma and collimation.

Also, if the stars themselves were 'removed' (by masking, etc.) it could be used to visualise any background gradients - perhaps it would have some use in just visualising the image extracted in a DBE operation.

I can see that, before too long, PixInsight will need an interface that allows it to drop a Process Container instance on each newly acquired image, as it arrives in a specified directory - to allow us imagers to see what our 'RAW' data looks like, dark and flat calibrated, perhaps even with a running 'average combine', maybe even Kalmann-filtered if required.

PixInsight - 'per PI ad astra'
Cheers,
Niall Saunders
Clinterty Observatories
Aberdeen, UK

Altair Astro GSO 10" f/8 Ritchey Chrétien CF OTA on EQ8 mount with homebrew 3D Balance and Pier
Moonfish ED80 APO & Celestron Omni XLT 120
QHY10 CCD & QHY5L-II Colour
9mm TS-OAG and Meade DSI-IIC

Offline David Serrano

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 503
3D star profile / Perfil estelar en 3D (BETA)
« Reply #26 on: 2009 April 12 14:19:56 »
I've noted a couple of strange behaviours in this script:



The red portion of the palette dominates half of the height. It seems like the beginning of the palette was situated near the largest star, at the lower left edge of the mesh, and that cells below that level were painted red. I think the first element of the palette should be assigned to black pixels in the source image, and the last element to white pixels.

The second weirdness is in the content of the defined preview. There seems to be a green arc along the star. It could be an artefact or it could be genuine, I don't know, but there doesn't seem to be any height change that justifies the color.

Nice donuts eh? ;)
--
 David Serrano

Offline Juan Conejero

  • PTeam Member
  • PixInsight Jedi Grand Master
  • ********
  • Posts: 7111
    • http://pixinsight.com/
3D star profile / Perfil estelar en 3D (BETA)
« Reply #27 on: 2009 April 12 16:46:19 »
New version with improved dialog and a few optimizations.

One of the changes is somewhat subtle but very important. In previous versions a function was used to calculate 3D rendition points and the limits of the rendered scene, namely:

Code: [Select]
function CreatePerspective(src, limits, perspecParams, minz)

The problem is that the limits argument was intended to be passed by reference, but that is impossible: in JavaScript, function parameters are always passed by value.

Luckily, limits was working as a by-reference argument (or the script wouldn't work at all), but this is only due to some peculiarities of my implementation (the way I've embedded Mozilla's JavaScript engine into PI Core, and how I've connected some internal PI objects to expose them through the JS runtime).

For this reason, I have replaced the old CreatePerspective function by a _3dplot_xform object that owns both the transformation's point cube (the points member) and the transformation's bounding rectangle (the limits member).

Code: [Select]
/*
    3DPlot v1.0
    A script to generate three-dimensional image renditions.
    Copyright (C) 2009  Andrés Pozo, David Serrano, Juan Conejero

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, version 3 of the License.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/

/*
    Changelog:
   1.0:   Several improvements to the user interface and a few optimizations.
          Replaced CreatePerspective() by a _3dplot_xform object.
          Some identifiers changed for improved naming coherency.
   0.9:   License, changelog, bare-bones user interface.
   0.8:   Smooth color transitions.
   0.7:   Reimplemented the possibility of rotating the 3D view.
   0.6:   Visualization now maps the height to a color palette.
   0.5:   The script can now be aborted by the user.
          The script shows progress information on the console.
          The perspective transformation points are now calculated faster.
          The MTF transformation is now carried out using a HT.
   0.4:   Optional shading effect added.
   0.3:   The resulting image shows the full extent of the 3D view.
          The code has been reorganized and structured.
          A MTF is applied to the image to improve the visualization.
          The perspective transformation has been simplified again.
          There is a couple of checks before starting the algorithm.
   0.2:   It now works on grayscale images.
          The 3D image is centered in the output image.
          The code is a bit simpler.
          It is now 7 times faster.
   0.1:   Initial test version.
*/

#define TITLE "3DPlot"
#define VERSION "1.0"

#include <pjsr/ColorSpace.jsh>
#include <pjsr/FillRule.jsh>
#include <pjsr/FrameStyle.jsh>
#include <pjsr/NumericControl.jsh>
#include <pjsr/UndoFlag.jsh>

#feature-id 3DPlot
#feature-info Please write something here.
//#feature-icon 3dplot.xpm

// Creates the parameters object.
function _3dplot_params()
{
   this.srcView = ImageWindow.activeWindow.currentView;
   this.azimuth = 30;    // Perspective angle in degrees
   this.elevation = 20; // Perspective elevation angle
   this.scaleXY = 6;    // Scale factor for X and Y axis
   this.scaleZ = 50;   // Scale factor for Z axis
   this.mtf=0.5;        // Midtones transfer value (0,1)
   this.backgroundColor=0xff403000;
   this.polygonFill=0xffffffff;
   this.polygonBorder=0x80000000;
   this.useShading=true; // Apply shading effect
   this.lightBrightness=2000; // Light intensity for the shading effect
   this.palette_elems = 256;
   this.palette = [ [0x80,0,0] , [0,0x80,0] , [0,0,0xC0], [0x80,0,0x80], [0x80,0x80,0], [0,0x80,0x80], [0x80,0x80,0x80] ];
}
var perspecParams = new _3dplot_params;

// Applies the perspective transformation to all the pixels in the image
function _3dplot_xform(src, perspecParams, minz)
{
   // Calculates the coordinates of each pixel applying the perspective transformation
   this.points=new Array;
   this.limits=new Rect( 1e10, 1e10, -1e10, -1e10 );

   // Modify the zscale in order to normalize the peak height
   // when the mtf changes
   var zscale=perspecParams.scaleZ/(1-minz);

   // Projection matrix
   var alpha=Math.rad(90-perspecParams.elevation);
   var beta=Math.rad(perspecParams.azimuth);
   var m00=Math.cos(beta);
   var m10=-Math.sin(beta);
   var m20=0;
   var m01=Math.cos(alpha)*Math.sin(beta);
   var m11=Math.cos(alpha)*Math.cos(beta);
   var m21=-Math.sin(alpha)*zscale;

   src.initializeStatus( "Computing 3D coordinates", src.height );

   for (var y = 0; y < src.height; y++) {
      this.points[y]=new Array;
      var m10y = m10*y;
      var m11y = m11*y;
      for (var x = 0; x < src.width; x++){
         var z = src.sample(x,y);
         var p = new Point( m00*x + m10y, m01*x + m11y + m21*z );
         p.mul( perspecParams.scaleXY );
         this.points[y][x] = p;
         if (p.x < this.limits.left)   this.limits.left = p.x;
         if (p.x > this.limits.right)  this.limits.right = p.x;
         if (p.y < this.limits.top)    this.limits.top = p.y;
         if (p.y > this.limits.bottom) this.limits.bottom = p.y;
      }
      src.advanceStatus( 1 );
   }

   gc();
}

function ApplyMTF(src, mtf)
{
   // Faster solution using a process instance
   var HT = new HistogramTransformation;
   with ( HT )
   {
      H = // c0, m, c1, r0, r1
      [[0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, 0.5, 1, 0, 1],
       [0, mtf, 1, 0, 1],
       [0, 0.5, 1, 0, 1]];
   }

   var wtmp = new ImageWindow( 1, 1, 1, 16, false, src.colorSpace != ColorSpace_Gray );
   var v = wtmp.mainView;

   v.beginProcess( UndoFlag_NoSwapFile );
   v.image.assign( src );
   v.endProcess();

   HT.executeOn( v, false ); // no swap file
   src.assign( v.image );

   wtmp.close();
}

function DieError(message)
{
   var msgb=new MessageBox(message,"Error generating 3D view");
   msgb.execute();
   throw Error( message );
}

function ApplyLighting(basecolor, light)
{
   var r=(basecolor[0]*light/1000);
   r=r>255?255:r;
   var g=(basecolor[1]*light/1000);
   g=g>255?255:g;
   var b=(basecolor[2]*light/1000);
   b=b>255?255:b;
   return 0xFF000000 | (r<<16)| (g<<8) | b;
}

// the resulting palette doesn't have to be exactly 'num' elements long.
function ExpandPalette(params)
{
   var p = params.palette;
   var num = params.palette_elems;
   var expanded = new Array;
   var steps = Math.round (num / p.length);  // steps between two provided palette elements

   for (var c = 0; c < p.length - 1; c++) {
      var from = p[c];
      var to = p[c+1];
      var step_red   = (to[0] - from[0]) / steps;
      var step_green = (to[1] - from[1]) / steps;
      var step_blue  = (to[2] - from[2]) / steps;
      for (s = 0; s < steps; s++) {
         var new_red   = from[0] + s * step_red;
         var new_green = from[1] + s * step_green;
         var new_blue  = from[2] + s * step_blue;
         expanded.push ([ new_red, new_green, new_blue ]);
      }
   }
   // add last user-supplied palette element
   expanded.push (p[p.length-1]);

   params.palette = expanded;
}

function RenderImage(src,i,limits,xform,perspecParams,minz)
{
   // Start of the process
   var bmp = new Bitmap (i.width, i.height);
   var g = new Graphics (bmp);
   g.antialiasing=true;

   // Applies a translation to the graphics to center the image
   g.translateTransformation(-limits.left,-limits.top);

   bmp.fill (perspecParams.backgroundColor);

   ExpandPalette (perspecParams);

   var fillbrush=[];
   if(!perspecParams.useShading){
      for(var c=0;c<perspecParams.palette.length;c++)
         fillbrush[c]=new Brush(0xFF000000 | (perspecParams.palette[c][0]<<16) | (perspecParams.palette[c][1]<<8) | perspecParams.palette[c][2]);
      g.pen =  new Pen (perspecParams.polygonBorder,0);
   } else
      // Using shading the polygon borders should be less visible
      g.pen =  new Pen ((perspecParams.polygonBorder&0x00FFFFFF) | 0x20000000);

   src.initializeStatus( "Rendering 3D profile", src.height-1 );
   // Paint the polygons from back to front
   for (var n = 0; n < src.height-1; n++) {
      for (var m = 0; m < src.width-1; m++) {
         var  z1=src.sample(m,n),
              z2=src.sample(m+1,n),
              z3=src.sample(m,n+1),
              z4=src.sample(m+1,n+1);

         // Get the palette index
         //var z=(z1+z2+z3+z4)/4;
         var zM=Math.max(Math.max(z1,z2),Math.max(z3,z4));
         var zm=Math.min(Math.min(z1,z2),Math.min(z3,z4));
         var z=(zm+zM)/2;
         z=(z-minz)/(1-minz); //rescale for mapping the palete to (minz,1)
         var palidx=Math.round(z*perspecParams.palette.length);
         palidx=palidx<0 ? 0 : (palidx>=perspecParams.palette.length ? perspecParams.palette.length-1 : palidx);

         if(perspecParams.useShading){
            // Get the lighting factor
            var slope=z1-z2+z3-z4;
            var lighting=(slope+0.5)*perspecParams.lightBrightness;
            lighting=lighting<0 ? 0 : Math.round(lighting);

            g.brush=new Brush(ApplyLighting(perspecParams.palette[palidx], lighting));
         } else
            g.brush=fillbrush[palidx];

         var polygon=new Array(
            xform[n][m],
            xform[n][m+1],
            xform[n+1][m+1],
            xform[n+1][m]);
         g.drawPolygon (polygon);
      }
      src.advanceStatus( 1 );
   }
   g.end();
   i.blend (bmp);
}

function _3dplot_dialog() {
   this.__base__ = Dialog;
   this.__base__();

   var labelWidth1 = this.font.width( "Polygon border color:" );
   var editWidth1 = 9*this.font.width( "0" );
   var editWidth2 = 12*this.font.width( "0" );

   // help label
   this.helpLabel = new Label (this);
   with (this.helpLabel) {
      frameStyle = FrameStyle_Box;
       margin = 4;
       wordWrapping = true;
       useRichText = true;
       text = "<p><b>" + TITLE + " v" + VERSION + "</b> &mdash; A " +
          "script to generate three-dimensional image renditions.</p>" +
          "<p>Copyright &copy; 2009 Andr&eacute;s Pozo / David Serrano / Juan Conejero</p>";
   }

   // source image

   this.srcImage_Label = new Label( this );
   this.srcImage_Label.minWidth = labelWidth1;
   this.srcImage_Label.text = "Source image:";
   this.srcImage_Label.textAlignment = TextAlign_Right|TextAlign_VertCenter;

   this.srcImage_ViewList = new ViewList( this );
   this.srcImage_ViewList.minWidth = 250;
   this.srcImage_ViewList.getAll(); // include main views as well as previews
   this.srcImage_ViewList.currentView = perspecParams.srcView;
   this.srcImage_ViewList.toolTip = "<p>Select the image to be rendered.</p>";
   this.srcImage_ViewList.onViewSelected = function( view )
   {
      perspecParams.srcView = view;
   };

   this.srcImage_Sizer = new HorizontalSizer;
   this.srcImage_Sizer.spacing = 4;
   this.srcImage_Sizer.add( this.srcImage_Label );
   this.srcImage_Sizer.add( this.srcImage_ViewList, 100 );

   // azimuth
   this.azimuth_NC = new NumericControl (this);
   with (this.azimuth_NC) {
      real = false;
      label.text = "Azimuth:";
      label.minWidth = labelWidth1;
      setRange (0, 90);
      slider.setRange (0, 90);
      slider.minWidth = 250;
      edit.minWidth = editWidth1;;
      setValue (perspecParams.azimuth);
      toolTip = "<p>Azimuth angle in degrees.</p>";
      onValueUpdated = function (value) {
        perspecParams.azimuth = value;
      }
   }

   // elevation
   this.elevation_NC = new NumericControl (this);
   with (this.elevation_NC) {
      real = false;
      label.text = "Elevation:";
      label.minWidth = labelWidth1;
      setRange (0, 90);
      slider.setRange (0, 90);
      slider.minWidth = 250;
      edit.minWidth = editWidth1;;
      setValue (perspecParams.elevation);
      toolTip = "<p>Observer's elevation angle above the ground, in degrees.</p>";
      onValueUpdated = function (value) {
         perspecParams.elevation = value;
      }
   }

   // scaleXY
   this.scaleXY_NC = new NumericControl (this);
   with (this.scaleXY_NC) {
      real = false;
      label.text = "X-Y plane scale:";
      label.minWidth = labelWidth1;
      setRange (1, 10);
      slider.setRange (1, 10);
      slider.minWidth = 250;
      edit.minWidth = editWidth1;;
      setValue (perspecParams.scaleXY);
      toolTip = "<p>Scale of X and Y coordinates in rendition pixels per image pixels.</p>";
      onValueUpdated = function (value) {
         perspecParams.scaleXY = value;
      }
   }

   // scaleZ
   this.scaleZ_NC = new NumericControl (this);
   with (this.scaleZ_NC) {
      real = false;
      label.text = "Z-axis scale:";
      label.minWidth = labelWidth1;
      setRange (1, 100);
      slider.setRange (1, 100);
      slider.minWidth = 250;
      edit.minWidth = editWidth1;;
      setValue (perspecParams.scaleZ);
      toolTip = "<p>Scaling factor of Z-axis coordinates.</p>";
      onValueUpdated = function (value) {
         perspecParams.scaleZ = value;
      }
   }

   // mtf
   this.mtf_NC = new NumericControl (this);
   with (this.mtf_NC) {
      label.text = "Midtones balance:";
      label.minWidth = labelWidth1;
      setRange (0, 1);
      slider.setRange (1, 500);
      slider.minWidth = 250;
      setPrecision (3);
      edit.minWidth = editWidth1;;
      setValue (perspecParams.mtf);
      toolTip = "<p>This parameter is part of a histogram transformation applied to " +
                "improve faint detail visualization.</p>";
      onValueUpdated = function (value) {
         perspecParams.mtf = value;
      }
   }

   // lightBrightness
   this.brightness_NC = new NumericControl (this);
   with (this.brightness_NC) {
      real = false;
      label.text = "Brightness:";
      label.minWidth = labelWidth1;
      setRange (100, 5000);
      slider.setRange (1, 50);
      slider.minWidth = 250;
      edit.minWidth = editWidth1;;
      setValue (perspecParams.lightBrightness);
      toolTip = "<p>Intensity of incident light.</p>";
      onValueUpdated = function (value) {
         perspecParams.lightBrightness = value;
      }
   }

   // useShading
   this.shading_CB = new CheckBox (this);
   with (this.shading_CB) {
      text = "Use shading";
      checked = perspecParams.useShading;
      onCheck = function (checked) { perspecParams.useShading = checked; }
      toolTip = "<p>If this option is selected, a special shading algorithm will be used " +
                "to enhance the 3-D rendition.</p>";
   }

   this.shading_Sizer = new HorizontalSizer;
   this.shading_Sizer.addSpacing( labelWidth1+4 );
   this.shading_Sizer.add( this.shading_CB );
   this.shading_Sizer.addStretch();

   // background color

   this.backgroundColor_Label = new Label( this );
   this.backgroundColor_Label.text = "Background color:";
   this.backgroundColor_Label.textAlignment = TextAlign_Right|TextAlign_VertCenter;
   this.backgroundColor_Label.minWidth = labelWidth1;

   this.backgroundColor_Edit = new Edit( this );
   this.backgroundColor_Edit.text = format( "%X", perspecParams.backgroundColor );
   this.backgroundColor_Edit.setFixedWidth( editWidth2 );
   this.backgroundColor_Edit.toolTip = "<p>Background color encoded as a 32-bit hexadecimal integer.<br/>" +
                                "(AARRGGBB format: AA=alpha (transparency), RR=red, GG=green, BB=blue)</p>";
   this.backgroundColor_Edit.onEditCompleted = function()
   {
      perspecParams.backgroundColor = parseInt( this.text, 16 );
      this.text = format( '%X', perspecParams.backgroundColor );
   };

   this.backgroundColor_Sizer = new HorizontalSizer;
   this.backgroundColor_Sizer.spacing = 4;
   this.backgroundColor_Sizer.add( this.backgroundColor_Label );
   this.backgroundColor_Sizer.add( this.backgroundColor_Edit );
   this.backgroundColor_Sizer.addStretch();

   // polygon fill color

   this.polygonFill_Label = new Label( this );
   this.polygonFill_Label.text = "Polygon fill color:";
   this.polygonFill_Label.textAlignment = TextAlign_Right|TextAlign_VertCenter;
   this.polygonFill_Label.minWidth = labelWidth1;

   this.polygonFill_Edit = new Edit( this );
   this.polygonFill_Edit.text = format( "%X", perspecParams.polygonFill );
   this.polygonFill_Edit.setFixedWidth( editWidth2 );
   this.polygonFill_Edit.toolTip = "<p>Polygon fill color encoded as a 32-bit hexadecimal integer.<br/>" +
                                "(AARRGGBB format: AA=alpha (transparency), RR=red, GG=green, BB=blue)</p>";
   this.polygonFill_Edit.onEditCompleted = function()
   {
      perspecParams.polygonFill = parseInt( this.text, 16 );
      this.text = format( '%X', perspecParams.polygonFill );
   };

   this.polygonFill_Sizer = new HorizontalSizer;
   this.polygonFill_Sizer.spacing = 4;
   this.polygonFill_Sizer.add( this.polygonFill_Label );
   this.polygonFill_Sizer.add( this.polygonFill_Edit );
   this.polygonFill_Sizer.addStretch();

   // polygon border color

   this.polygonBorder_Label = new Label( this );
   this.polygonBorder_Label.text = "Polygon border color:";
   this.polygonBorder_Label.textAlignment = TextAlign_Right|TextAlign_VertCenter;
   this.polygonBorder_Label.minWidth = labelWidth1;

   this.polygonBorder_Edit = new Edit( this );
   this.polygonBorder_Edit.text = format( "%X", perspecParams.polygonBorder );
   this.polygonBorder_Edit.setFixedWidth( editWidth2 );
   this.polygonBorder_Edit.toolTip = "<p>Polygon border color encoded as a 32-bit hexadecimal integer.<br/>" +
                                "(AARRGGBB format: AA=alpha (transparency), RR=red, GG=green, BB=blue)</p>";
   this.polygonBorder_Edit.onEditCompleted = function()
   {
      perspecParams.polygonBorder = parseInt( this.text, 16 );
      this.text = format( '%X', perspecParams.polygonBorder );
   };

   this.polygonBorder_Sizer = new HorizontalSizer;
   this.polygonBorder_Sizer.spacing = 4;
   this.polygonBorder_Sizer.add( this.polygonBorder_Label );
   this.polygonBorder_Sizer.add( this.polygonBorder_Edit );
   this.polygonBorder_Sizer.addStretch();

   // ### TODO: Better color selection controls - Include a ColorSelectionDialog object in PJSR?

   // ### TODO: Allow selecting palettes

   // buttons
   this.ok_Button = new PushButton (this);
   this.ok_Button.text = "OK";
   this.ok_Button.onClick = function() { this.dialog.ok(); };

   this.cancel_Button = new PushButton (this);
   this.cancel_Button.text = "Cancel";
   this.cancel_Button.onClick = function() { this.dialog.cancel(); };

   this.buttons_Sizer = new HorizontalSizer;
   this.buttons_Sizer.spacing = 8;
   this.buttons_Sizer.addStretch();
   this.buttons_Sizer.add (this.ok_Button);
   this.buttons_Sizer.add (this.cancel_Button);

   // pack everything
   this.sizer = new VerticalSizer;
   with (this.sizer) {
      margin = 8;
      spacing = 6;
      add (this.helpLabel);
      addSpacing (4);
      add (this.srcImage_Sizer);
      add (this.azimuth_NC);
      add (this.elevation_NC);
      add (this.scaleXY_NC);
      add (this.scaleZ_NC);
      add (this.mtf_NC);
      add (this.brightness_NC);
      add (this.shading_Sizer);
      add (this.backgroundColor_Sizer);
      add (this.polygonFill_Sizer);
      add (this.polygonBorder_Sizer);
      add (this.buttons_Sizer);
   }

   this.windowTitle = TITLE + " v" + VERSION;
   this.adjustToContents();
   this.setFixedSize();
}
_3dplot_dialog.prototype = new Dialog;

function FullViewIdAsValidViewId( fullId )
{
   return fullId.replace( "->", "_" );
}

function main()
{
   if(ImageWindow.activeWindow.isNull)
      DieError("There is no active image");

   console.hide();

   for ( ;; )
   {
      if (!(new _3dplot_dialog).execute())
         return;

      if ( !perspecParams.srcView.isNull )
         break;

      (new MessageBox( "No source view has been selected!",
                       TITLE, StdIcon_Error, StdButton_Ok )).execute();
   }

   console.show();
   console.writeln( "<end><cbr><br>***** 3D Profiling Script *****" );
   console.flush();

   var startts = new Date;

   // Extract the luminance of the source image
   var src = new Image();
   perspecParams.srcView.image.extractLuminance(src);

   if( perspecParams.mtf!=0.5)
      ApplyMTF(src, perspecParams.mtf);

   // Allow the user to abort this script
   console.abortEnabled = true;

   // Allow status monitoring for our working image
   src.statusEnabled = true;

   // The median of the source image is the level of the "floor" of the 3D image
   var minz=src.median();

   // Create the perspective
   var xform=new _3dplot_xform(src, perspecParams, minz);
   //with(xform.limits) console.writeln(format("%f %f %f %f",left,top,right,bottom));

   // Create the output window
   var newid = FullViewIdAsValidViewId( perspecParams.srcView.fullId ) + "_3dplot";
   var w = new ImageWindow (Math.round(xform.limits.width),
                            Math.round(xform.limits.height), 3, 8, false, true, newid);
   try{
      var v = w.mainView;
      var i = v.image;

      v.beginProcess(UndoFlag_NoSwapFile);
      RenderImage(src, i, xform.limits, xform.points, perspecParams, minz);
      v.endProcess();

      w.show();

      var endts = new Date;
      console.writeln(format ("<br />3D view: %.2f s",(endts.getTime() - startts.getTime()) / 1000));
   } catch(err)
   {
      w.close();
      console.writeln(err);
   }
}

main();
Juan Conejero
PixInsight Development Team
http://pixinsight.com/

Offline Andres.Pozo

  • PTeam Member
  • PixInsight Padawan
  • ****
  • Posts: 927
3D star profile / Perfil estelar en 3D (BETA)
« Reply #28 on: 2009 April 13 02:00:14 »
Quote from: "David Serrano"
I've noted a couple of strange behaviours in this script:
The red portion of the palette dominates half of the height. It seems like the beginning of the palette was situated near the largest star, at the lower left edge of the mesh, and that cells below that level were painted red. I think the first element of the palette should be assigned to black pixels in the source image, and the last element to white pixels.


It seems that this image has been generated using a very low mtf value. The algorithm is using the median of the image (after applying the mtf) to set the origin of the palette. All the points lower than the median are assigned the first element of the palette. With a very low mtf the noise of the image is magnified and also the range of values lower than the median.
We could try to find another value for the origin of the palette, but with normal mtf's, the median works fine. The minimum z could be an option, but the cold pixels would distort the palette. Perhaps we could try finding the value in the percentile 1% of the histogram or something similar.

Also, the lighting function is a quite simple approximation. It multiplies the lighting factor by the RGB channels of the base color. The black color can not be used because the lighting function would always return 0. The effect of "black" would be achieved using a dark (20%?) gray.

Offline David Serrano

  • PTeam Member
  • PixInsight Guru
  • ****
  • Posts: 503
3D star profile / Perfil estelar en 3D (BETA)
« Reply #29 on: 2009 April 13 14:55:15 »
Quote from: "Andres.Pozo"
It seems that this image has been generated using a very low mtf value.


Not exactly. The image was bright in itself because it's part of M45 nebulosity. The largest star is Alcyone, the brightest one in the cluster.


Quote from: "Andres.Pozo"
The minimum z could be an option, but the cold pixels would distort the palette.


I, as a user, would see no distortion in the cold pixels. After all, if the background in my image isn't absolute black, the background in the generated 3D map shouldn't be absolute red (or whatever color was the first in the palette). I guess we have two equally valid points of view over this matter ;).
--
 David Serrano